Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InCB derivation fix #679

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Feb 1, 2024

See https://github.com/unicode-org/properties/issues/238.

[179-C26] Consensus: Change the derivation of Indic_Conjunct_Break = Extend to exclude only those characters that are Indic_Conjunct_Break=Linker or Indic_Conjunct_Break=Consonant from the set of nonstarters with Grapheme_Cluster_Break=Extend. For Unicode Version 16.0. See document L2/24-064 item 5.3.

[179-A100] Action Item for Robin Leroy, PAG: In DerivedCoreProperties.txt, update the Indic_Conjunct_Break assignments according to the corrected derivation. For Unicode Version 16.0. See document L2/24-064 item 5.3.

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eggrobin eggrobin force-pushed the incb-derivation-fix branch from 51fdd68 to 68cbc46 Compare April 25, 2024 19:59
@eggrobin eggrobin marked this pull request as ready for review April 30, 2024 19:18
@eggrobin eggrobin requested a review from markusicu April 30, 2024 19:18
@eggrobin eggrobin merged commit 8d4e181 into unicode-org:main Apr 30, 2024
23 checks passed
.Consonant)),
"Consonant")
.putAll(incbLinker, "Linker")
.putAll(incbConsonant, "Consonant")
.putAll(
gcb.getSet("Extend")
.removeAll(ccc.getSet("Not_Reordered"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eggrobin This still removes ccc=0 so

  • [179-C31] Consensus: Change the derivation of InCB=Extend to [\p{gcb=Extend}\p{gcb=ZWJ}-\p{InCB=Linker}-\p{InCB=Consonant}-[\u200c]]. For Unicode Version 16.0. See document L2/24-064 item 5.8.

is not done yet in this code, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants