Move VersionedProperty to its own file #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macchiati
reviewed
Jan 15, 2024
| private UnicodeProperty property; | ||
| private final transient PatternMatcher matcher = new UnicodeProperty.RegexMatcher(); | ||
|
|
||
| private static final Set<String> TOOL_ONLY_PROPERTIES = |
There was a problem hiding this comment.
BTW, just checked in changes to a PR so that the normalization code can use the IndexUnicodeProperties.
macchiati
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #432 and #502.
I want to do #432 (versioned property support in the JSPs) together with #502 (using unicodetools properties rather than ICU properties and properties badly reverse-engineered from ICU in the JSPs), otherwise we would lose the capability to have β properties.
That means splitting out the VersionedProperty class which is currently in the invariants test to someplace more reasonable for use in the JSPs.
I am trying to make this a « no functional change » PR, so while I am touching weird usages in UTS39-related generators that were reaching into the tests, I am not going to try to improve those.
The changes to VersionedProperty are minimal to get things to compile. They are quite hard to review because of the move, so I want to make any meaningful changes (and I will need to make changes for #432) in a separate PR; again I am trying very hard not to improve anything here. See https://goomics.net/119/.