Add MakeUnicodeFiles.java option #636
Conversation
…es after building
unicodetools/src/main/java/org/unicode/text/UCD/MakeUnicodeFiles.java
Outdated
Show resolved
Hide resolved
unicodetools/src/main/java/org/unicode/text/UCD/MakeUnicodeFiles.java
Outdated
Show resolved
Hide resolved
unicodetools/src/main/java/org/unicode/text/UCD/MakeUnicodeFiles.java
Outdated
Show resolved
Hide resolved
unicodetools/src/main/java/org/unicode/text/UCD/MakeUnicodeFiles.java
Outdated
Show resolved
Hide resolved
| @@ -53,7 +59,64 @@ public class MakeUnicodeFiles { | |||
| static boolean DEBUG = false; | |||
|
|
|||
| public static void main(String[] args) throws IOException { | |||
|
|
|||
| boolean clean = Arrays.asList(args).contains("-c"); | |||
There was a problem hiding this comment.
How about a more self-explanatory option string, something like "--cleanBin" ?
There was a problem hiding this comment.
ping -- longer option names make reading and documenting command lines much easier
| generateFile(); | ||
|
|
||
| if (clean) { |
There was a problem hiding this comment.
I find it surprising/confusing that the "clean" option should also drive copying the files back to the input.
It would be better to make another new option like "--changesToInput" .
There was a problem hiding this comment.
ping -- I really think it would be better to make a second option, with another readable option name (not just renaming the Java variable)
There was a problem hiding this comment.
I don't disagree with @markusicu but from the standpoint of practicality, do we see ourselves or anyone else using one option without the other?
|
Markus, I'm going to go ahead and merged. It it comes to the point where someone needs 2 options (or more options need to be added) I can do additional work then. |
#627
Adds option to clean directory before building, then copy relevant files after building, as per issue