-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jsp): use OIDC/IF to upload #622
base: main
Are you sure you want to change the base?
Conversation
- per https://cloud.google.com/blog/products/identity-security/enabling-keyless-authentication-from-github-actions - Won't work yet due to admin snags - NOTE: temporarily pushes on every commit to this branch For #46
OK I think this is ready to go pending clearing admin hurdles.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OIDC stuff looks approximately right; we use it already in ICU4X to upload things to the project "dev-infra-273822". However, we can't yet create a provider for the project "goog-unicode-dev" as proposed in this PR.
is Thanks… i tried to make it so it's ready to go once the auth stuff is cleared |
@srl295 PR from December, in draft state. Are you intending to continue work here and take it out of "draft", for review? |
I pinged again for an update. Google link: b/303659622 |
For #46
Note this is just the automated deployment, see #621 for an update to the documentation.