Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kawi sign nukta #567

Merged
merged 9 commits into from
Nov 10, 2023
Merged

Kawi sign nukta #567

merged 9 commits into from
Nov 10, 2023

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Oct 9, 2023

[173-C28] Consensus: Accept U+11F5A KAWI SIGN NUKTA, with name, glyph, and properties as given in L2/22-236 for a future version of the Unicode Standard. (Ref. section 8 of L2/22-248)

Checked consistency with Ken’s UnicodeData (draft 8) and LineBreak (draft 3).

roozbehp
roozbehp previously approved these changes Nov 10, 2023
Copy link
Contributor

@roozbehp roozbehp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roozbehp
Copy link
Contributor

If Nukta⟹Diacritic, perhaps add an invariant?

@eggrobin
Copy link
Member Author

If Nukta⟹Diacritic, perhaps add an invariant?

Yes, but we will need to change the assignment for those nuktas that are not called nuktas; I added that to https://github.com/unicode-org/properties/issues/195#issuecomment-1804962555.

@roozbehp
Copy link
Contributor

Yes, but we will need to change the assignment for those nuktas that are not called nuktas; I added that to unicode-org/properties#195 (comment).

Can't you add temporary exceptions?

@markusicu
Copy link
Member

@echeran reminder, you are the assignee = voluntold main reviewer :-)

@eggrobin
Copy link
Member Author

Can't you add temporary exceptions?

Done.

Copy link
Contributor

@roozbehp roozbehp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eggrobin eggrobin merged commit 1f791fe into unicode-org:main Nov 10, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants