Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the UCA checks into their own job, check UCD consistency #562

Merged
merged 17 commits into from
Oct 9, 2023

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Oct 7, 2023

The ucd-and-smoke-tests job will leave an error message in the diff on every file that needs to be regenerated with MakeUnicodeFiles, see https://github.com/unicode-org/unicodetools/pull/562/files/81e0e3708a2e26fe89b46b95b487e44eebc63e67 (scroll to the bottom).

See multiple threads on properties@ and #445 (comment).

@markusicu markusicu requested a review from echeran October 7, 2023 06:10
@markusicu
Copy link
Member

major credit for creative commit messages!

@eggrobin
Copy link
Member Author

eggrobin commented Oct 7, 2023

major credit for creative commit messages!

@robertbastian once told me about a PR on ICU4X that my commit messages tell a story, and that’s definitely the case here (I was testing with the build on push on eggrobin/unicodetools, but the tree was being checked out from unicode-org/unicodetools, so I was running the Python script without my changes…).

@@ -17,9 +17,10 @@


def main():
out_of_source = '--out-of-source' in sys.argv[1:]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a reminder for our future selves: if we need to use additional args for this script, we should probably make use of Python's argparse module for robust handling. Not a concern for this PR though.

Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸 LGTM and I'm happy you were able to make use of the Python script

@eggrobin eggrobin merged commit c0ae922 into unicode-org:main Oct 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants