Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invariant for lb=AS numbers #537

Merged
merged 6 commits into from
Nov 3, 2023
Merged

Invariant for lb=AS numbers #537

merged 6 commits into from
Nov 3, 2023

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Aug 31, 2023 •
edited
Loading

See UTC-177-C46. Fix #534.
See unicode-org/properties#126.

Currently fails as expected:

# Digits are lb=AS in scripts with brahmic line breaking.

[\p{GC=Nd} & $BrahmicLineBreaking] ⊆ \p{LB=AS}

**** START Test Failure 1 ****
## Expected empty, got: 40 [\u1B50-\u1B59\uA9D0-\uA9D9\uAA50-\uAA59\U00011950-\U00011959]

## In [\p{GC=Nd} & $BrahmicLineBreaking]

## But Not In \p{LB=AS}

1B50..1B59	#	[10]	(᭐..᭙)	BALINESE DIGIT ZERO..BALINESE DIGIT NINE
A9D0..A9D9	#	[10]	(꧐..꧙)	JAVANESE DIGIT ZERO..JAVANESE DIGIT NINE
AA50..AA59	#	[10]	(꩐..꩙)	CHAM DIGIT ZERO..CHAM DIGIT NINE
11950..11959	#	[10]	(𑥐..𑥙)	DIVES AKURU DIGIT ZERO..DIVES AKURU DIGIT NINE
**** END Test Failure 1 ****

@eggrobin
Invariant for unicode-org/properties#126
693ac12
@eggrobin
Change the Line_Break property of the Balinese, Javanese, Cham, and D…
63755a3 
…ives Akuru digits, namely U+1B50..U+1B59, U+A9D0..U+A9D9, U+AA50..U+AA59, and U+11950..U+11959, from Ideographic to Aksara_Start.
@eggrobin
Merge remote-tracking branch 'la-vache/main' into lb=AS-for-all
07f1a4a
markusicu
markusicu previously approved these changes Sep 22, 2023
View reviewed changes
markusicu
markusicu previously approved these changes Sep 22, 2023
View reviewed changes
@markusicu
Copy link
Member

ready to take out of draft and merge?

@eggrobin
Copy link
Member Author

eggrobin commented Oct 3, 2023

ready to take out of draft and merge?

No, waiting on UTC-177 decision, see https://github.com/unicode-org/properties/issues/126.

I’ll merge it once Peter says we have a consensus :-)

@markusicu
Copy link
Member

I added a new "wait-for-UTC" label.

@eggrobin eggrobin marked this pull request as ready for review November 3, 2023 18:19
markusicu
markusicu previously approved these changes Nov 3, 2023
View reviewed changes
@eggrobin eggrobin requested a review from markusicu November 3, 2023 21:08
@eggrobin eggrobin merged commit af8fba6 into unicode-org:main Nov 3, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eggrobin @markusicu