Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tulu-Tigalari #524

Merged
merged 46 commits into from
Nov 10, 2023
Merged

Tulu-Tigalari #524

merged 46 commits into from
Nov 10, 2023

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Aug 18, 2023

UTC-170-C9 Consensus: UTC accepts 78 Tulu-Tigalari characters in a new Tulu-Tigalari block U+11380..U+113FF as documented in L2/22-031, for encoding in a future version of the standard.

UTC-176-C16 Consensus: The UTC approves the code point change for TULU-TIGALARI LETTER DHA to U+113A4, from the conflicting U+113A5 approved by UTC-170-C9. TULU-TIGALARI LETTER NA remains at U+113A5.

Plus correcting a typo in the InSC data from L2/22-031.

LineBreak according to L2/22-080.

@eggrobin
Copy link
Member Author

eggrobin commented Oct 2, 2023

Checked consistency with Ken’s UnicodeData-16.0.0d6.txt and LineBreak-16.0.0d2.txt.

@eggrobin
Copy link
Member Author

eggrobin commented Oct 2, 2023

CI fails because of an invariant test which probably stems from the InPC and InSC files being garbled. (Nevermind, I misunderstood the test failure) I should try to regenerate them like I did for UnicodeData, LineBreak, etc.

@eggrobin
Copy link
Member Author

eggrobin commented Oct 3, 2023

CI does not pass because of collation.

@eggrobin eggrobin marked this pull request as ready for review October 9, 2023 15:08
@eggrobin
Copy link
Member Author

Ken noted that the avagraha should probably be LB=BA like Grantha, but L2/22-080R2 recommends LB=ID.
Sent an email to Norbert to see if the discrepancy was intentional.

@eggrobin
Copy link
Member Author

The discrepancy was intentional.

Scripsit Norbert:

For Tulu-Tigalari, one of the experts told us that line breaks can occur pretty much at any spacing character. OpenType doesn’t let you reorder characters across line breaks, and doesn’t deal well with line breaks before combining marks, so we can’t quite replicate that. But avagrahas with gc=Lo are treated as a base, so there’s no problem with breaking before them.

@markusicu
Copy link
Member

Several non-UCA CI failures...

@eggrobin eggrobin requested a review from roozbehp November 10, 2023 20:40
Copy link
Contributor

@roozbehp roozbehp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eggrobin eggrobin merged commit 926ddff into unicode-org:main Nov 10, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants