Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop selection from :currency and :unit #991

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eemeli
Copy link
Collaborator

@eemeli eemeli commented Jan 27, 2025

As discussed today, we should leave out selection from :currency and :unit for now, as it's not clear that data is available to select correct plural values for them. For example, consider how the English phrase "$3 is your total price" refers to the currency value in the singular.

If/once selection on these values is better defined, we should consider adding support for that in MF2.

Where necessary, plural selection on the numerical values of currencies and unitized values is still possible via :number and :integer, which do support selection.

@eemeli eemeli added registry Issue pertains to the function registry LDML47 LDML 47 Release (Stable) labels Jan 27, 2025
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If something doesn't work even in English, then it most likely is even worse in other languages. This is also a compelling reason to keep these functions separate from :number. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LDML47 LDML 47 Release (Stable) registry Issue pertains to the function registry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants