Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification to default bidi strategy #968

Merged
merged 9 commits into from
Jan 13, 2025
Merged

Clarification to default bidi strategy #968

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
76ca624
Add note elaborating on what the directionality of the resolved value…
catamorphism Dec 9, 2024
bb37ee7
Avoid breaking up algorithm steps with NOTE
catamorphism Dec 9, 2024
dd52758
Incorporate feedback from Eemeli
catamorphism Dec 16, 2024
b78ec62
Avoid repetition
catamorphism Dec 16, 2024
80c5b25
Rewrite to not define an auxiliary function
catamorphism Dec 16, 2024
fd6be39
Incorporate feedback from Eemeli
catamorphism Dec 20, 2024
7896fbf
Add directionality methods to MessageValue
catamorphism Dec 20, 2024
2e503e3
Update spec/formatting.md
catamorphism Dec 30, 2024
162b7bb
Update spec/formatting.md
catamorphism Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 33 additions & 3 deletions spec/formatting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,13 @@ identifies not only the name of the external input value,
but also the _variable_ to which the _resolved value_ of the _variable-expression_ is bound.

In a _pattern_, the _resolved value_ of an _expression_ or _markup_ is used in its _formatting_.
To support the _Default Bidi Strategy_,
the _resolved value_ of each _expression_
SHOULD include information about the directionality
of its formatted string representation,
as well as a flag to indicate whether
its formatted representation requires isolation
from the surrounding text.

The form that _resolved values_ take is implementation-dependent,
and different implementations MAY choose to perform different levels of resolution.
Expand All @@ -146,6 +153,8 @@ and different implementations MAY choose to perform different levels of resoluti
> getValue(): unknown
> resolvedOptions(): { [key: string]: MessageValue }
> selectKeys(keys: string[]): string[]
> directionality(): 'LTR' | 'RTL' | 'unknown'
> isolate(): boolean
> }
> ```
>
Expand Down Expand Up @@ -940,11 +949,12 @@ The _Default Bidi Strategy_ is defined as follows:
Note that this is normally the empty string.
1. Append `fmt` to `out`.
1. Else:
1. Let `fmt` be the formatted string representation of the _resolved value_ of `part`.
1. Let `dir` be the directionality of `fmt`,
1. Let `resval` be the _resolved value_ of `part`.
1. Let `fmt` be the formatted string representation of `resval`.
1. Let `dir` be the directionality of `resval`,
one of « `'LTR'`, `'RTL'`, `'unknown'` », with the same meanings as for `msgdir`.
1. Let the boolean value `isolate` be
True if the `u:dir` _option_ of the _resolved value_ of `part` has a value other than `'inherit'`,
True if the `u:dir` _option_ of `resval` has a value other than `'inherit'`,
or False otherwise.
1. If `dir` is `'LTR'`:
1. If `msgdir` is `'LTR'` and `isolate` is False:
Expand All @@ -963,4 +973,24 @@ The _Default Bidi Strategy_ is defined as follows:
1. Append U+2069 POP DIRECTIONAL ISOLATE to `out`.
1. Emit `out` as the formatted output of the message.

> [!NOTE]
> As mentioned in the "Resolved Values" section,
> the representation of a _resolved value_
> can track everything needed
> to determine the directionality
> of the formatted string representation
> of a _resolved value_.
> Each _function handler_ can have its own means
> for determining the directionality annotation
> on the _resolved value_ it returns.
> Alternately, an implementation could simply
> determine directionality
> based on the locale.

> [!IMPORTANT]
> Directionality SHOULD NOT be determined by introspecting
> the character sequence in the formatted string representation
> of `resval`.