Align test schema with error spec #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mradbourne
force-pushed
the
align-test-schema-with-error-spec
branch
from
5e504ca to
5de7d63
Compare
mradbourne
commented
May 29, 2024
| @@ -11,7 +11,7 @@ | |||
| "exp": "{:date}", | |||
| "expErrors": [ | |||
| { | |||
| "type": "invalid-expression" | |||
| "type": "bad-operand" | |||
There was a problem hiding this comment.
Just highlighting an assumption I've made:
This test results in bad-operand because it is effectively being passed an operand of 'undefined', which is not compatible with the :date function.
mradbourne
requested review from
aphillips,
catamorphism,
eemeli,
srl295,
echeran and
mihnita
aphillips
approved these changes
May 29, 2024
eemeli
approved these changes
May 30, 2024
There was a problem hiding this comment.
@aphillips This does include a couple of bad-option errors as well. But we definitely need more tests; many of the errors will need to use :test:function to be triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error spec has been recently updated. This PR brings the test schema and existing tests in-line with the latest error definitions.