Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanding build documentation #39

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Expanding build documentation #39

merged 1 commit into from
Dec 18, 2024

Conversation

nciric
Copy link
Contributor

@nciric nciric commented Dec 18, 2024

Expanding README.md with pointers to ICU4C, ICU_ROOT path rules etc. and restructuring the build section.

@nciric nciric requested a review from grhoten December 18, 2024 18:29
grhoten
grhoten approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@grhoten grhoten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this resolve issue #38?

@nciric
Copy link
Contributor Author

nciric commented Dec 18, 2024

Does this resolve issue #38?

No I still have the same issue. But it clarifies how to get ICU4C, and tips we discovered in #38 .

@nciric nciric merged commit 21cd778 into main Dec 18, 2024
1 check passed
@nciric nciric deleted the cira branch December 18, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grhoten grhoten grhoten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nciric @grhoten