Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17885 Add Sunu-Deva and Deva-Sunu transforms #4214

Open
wants to merge 2 commits into
base: ddl/v48
Choose a base branch
from

Conversation

NeilSureshPatel
Copy link

@NeilSureshPatel NeilSureshPatel commented Nov 26, 2024

CLDR-17885

Initial commit of Sunuwar to Devanagari and Devanagari to Sunuwar transforms using the InterIndic intermediate step. Transforms are based on the SWS standard.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great so far and note that it is draft=contributed.

Are you able to add test data? See https://github.com/unicode-org/cldr/tree/main/common/testData/transforms (note the _readme.txt there)

@NeilSureshPatel
Copy link
Author

I think this is great so far and note that it is draft=contributed.

Are you able to add test data? See https://github.com/unicode-org/cldr/tree/main/common/testData/transforms (note the _readme.txt there)

I can pull together some test data as I get time to assemble it.

@srl295 srl295 changed the base branch from main to ddl/v48 January 18, 2025 16:50
@srl295
Copy link
Member

srl295 commented Jan 21, 2025

CLDR-17885
Initial commit of Sunuwar to Devanagari and Devanagari to Sunuwar transforms using the InterIndic intermediate step. Transforms are based on the SWS standard. Included initial deva-t-sunu TestData

Create deva-t-sunu.txt

Initial test data set for quick validation of transforms
@NeilSureshPatel NeilSureshPatel force-pushed the CLDR-17885-Sunuwar-Transforms branch from 89af1ec to e3ee82c Compare January 22, 2025 00:11
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@NeilSureshPatel
Copy link
Author

I think I got it squashed properly, but let me know if need to do something else

@srl295
Copy link
Member

srl295 commented Jan 22, 2025

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants