Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18017 Update site map ordering #4203

Merged
merged 2 commits into from
Nov 21, 2024
Merged

CLDR-18017 Update site map ordering #4203

merged 2 commits into from
Nov 21, 2024

Conversation

AEApple
Copy link
Contributor

@AEApple AEApple commented Nov 18, 2024

CLDR-18017

Update site map to re-order the releases/downloads page and requesting changes page higher in the nav bar on the CLDR home page

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

Update site map to re-order the releases/downloads page and requesting changes page higher

See #4203
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@github-actions github-actions bot added the Site Update Updates docs/site label Nov 18, 2024
Copy link

✨ deployed to https://9176fc73.cldr.pages.dev

Copy link

✨ deployed to https://2be1a88d.cldr.pages.dev

index/cldr-spec/transliteration-guidelines
index/cldr-spec/definitions
index/bcp47-extension
requesting_changes
index/downloads
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to have index/downloads before requesting changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of expect most people to follow the news item to the latest release instead of the nav bar but I could be wrong.

Okay, so this ordering?

  • CLDR Releases
  • CLDR Spec
  • CLDR Charts
  • Requesting changes
  • Acknowledgements
  • General Information
  • Information Hub for Linguists
  • CLDR Technical Committee
  • Schedule
  • Internal Development (I'm not sure why we have this from the front page instead of a sub section of the TC)
  • Archived Pages (I'm not sure why we have this from the front page, but I'm not sure where it would fit)
  • CLDR Site Map

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that works.

On schedule, we might put that right below General info

  • For internal development, it is handy for us to have it at the top level
  • For archived pages, it's hard to know where else to put it. They are mostly (but I think not all) internal development.

Note: we could also have Steven extend the site map tooling to allow for the following, if we want more flexibility.

  • Having pages in multiple locations
  • Hiding pages (we want to make that explicit, so we don't inadvertantly skip a page).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG! Let me put together an updated commit for review.

@AEApple AEApple requested a review from macchiati November 18, 2024 02:00
@AEApple AEApple marked this pull request as ready for review November 18, 2024 02:00
Copy link

✨ deployed to https://fb1a710e.cldr.pages.dev

@AEApple AEApple merged commit 2103e9c into main Nov 21, 2024
14 checks passed
@AEApple AEApple deleted the AEApple-CLDR-18017 branch November 21, 2024 00:40
@AEApple
Copy link
Contributor Author

AEApple commented Nov 21, 2024

Merging the change. If anyone has any follow up feedback we can always adjust the order if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Update Updates docs/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants