Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18061 Bump CLDR versions (except spec); update coverage to fix test failures #4162

Merged

Conversation

pedberg-icu
Copy link
Contributor

CLDR-18061

  • This PR completes the ticket.
  • Update README date, version; status was already OK
  • Update cldrVersion in dtd and xsd files.
  • Update CLDR version in pom files
  • Update GEN_VERSION in CLDRFile
  • Update DEV_VERSION in ToolConstants.java, and add entries for CLDR 45 in CLDR_VERSIONS and in CldrVersion.java.
  • Did not update spec version, that is a separate BRS task and will be covered by a separate ticket (and PR)
  • Also updated coverage to fix some test failures:
    • To fix failure in unittest.TestCLDRLocaleCoverage.TestLanguageNameCoverage, added the following to coverageVariable key="%language80":
      • ak Akan
      • ee Ewe
      • gaa Ga
      • ii Sichuan Yi
      • nso Northern Sotho
      • om Oromo
      • rw Kinyarwanda
      • st Southern Sotho
      • tn Tswana
    • To fix failure in util.TestLevel.testModernCurrencies, added the following to coverageVariable key="%currency80":
      • ZWG

ALLOW_MANY_COMMITS=true

srl295
srl295 previously approved these changes Oct 26, 2024
@pedberg-icu pedberg-icu force-pushed the CLDR-18061-bump-cldr-version-numbers branch from 74522b2 to b4ee5e0 Compare October 26, 2024 02:37
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@pedberg-icu
Copy link
Contributor Author

@srl295 Thanks for the initial review. I had missed the version update in docs/charts/keyboards/pom.xml because the path changed (keyboards plural), and just fixed that. Please re-stamp when you get a chance.

@pedberg-icu pedberg-icu merged commit 1db6850 into unicode-org:main Oct 26, 2024
13 checks passed
@pedberg-icu pedberg-icu deleted the CLDR-18061-bump-cldr-version-numbers branch October 26, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants