CLDR-18001 site: fix link in ToC to entire page, fix some titles #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if the first H1 is the same as the title, change the href in the ToC to go to the entire page - If there isn't a redundant H1 , synthesize an entry in the ToC
|
✨ deployed to https://cf52a071.cldr.pages.dev |
macchiati
previously approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Looks good.
BTW
- We definitely need a page explaining the title requirements. Not part of GFM and not documented that quotes are required. (What happens if they aren't there??)
- I think we need to drop the first line of the contents; I'd added that to https://unicode-org.atlassian.net/browse/CLDR-18017. But that can be later.
- related to CLDR-18017 - suppress redundant h1 (#), but add centered title - suppress title from ToC. Hide ToC if empty.
if not there the PR may reject or it may truncate. I updated the doc
Sorry, inflight merge conflict. - the same instant you were reviewing, I was reading and implementing CLDR-18017 which dropped your review. |
|
✨ deployed to https://34c47ec7.cldr.pages.dev |
macchiati
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18001
suppress link to title in ToC, hide ToC if empty
suppress title h1 entirely, add centered title
shift ToC over to the left one
This PR completes the ticket.
ALLOW_MANY_COMMITS=true
Review Notes