-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-18001 site: add Contents to sidebar, fix arrow #4121
Conversation
- fix subpage arrow to not conflict
- for now, just a flat list of all headings
✨ deployed to https://727d250d.cldr.pages.dev |
- Subpages was indented too much, should be on the same level as Contents
@btangmu very minor update, the subpage header "Subpages" was itself inside a subpage container, so was indented too much. |
✨ deployed to https://b2a64026.cldr.pages.dev |
Looks good. I presume that a later PR will combine the Contents and Subpages. BTW, having the >> in a line at the end of Subpages doesn't look good, and has collisions. |
|
with a nbsp |
Right, I'm assuming that this will combine the two boxes (I just can't see that on https://b2a64026.cldr.pages.dev/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great. Any refinement can come in later PR.
- update per review comment- use nbsp instead of float right for arrow symbol - also, remove a debug printout
✨ deployed to https://ed11b4dc.cldr.pages.dev |
That was a bug, now fixed. |
Take a look now, image above and preview link coming soon. |
@macchiati boxes now merged…
|
Looks great, let's merge! |
CLDR-18001
adds Contents section to sidebar, with auto-link headers. For now, it just has a flat list of headings and doesn't try to sort out the nesting.
Fix an issue with the "subpage" arrow so it doesn't collide.
This PR completes the ticket.
ALLOW_MANY_COMMITS=true
Review Notes
View the main page and use the Contents to navigate to a link within the page.
Updated the right-arrow to be an nbsp: