Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18001 site: add Contents to sidebar, fix arrow #4121

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 9, 2024

CLDR-18001

  • adds Contents section to sidebar, with auto-link headers. For now, it just has a flat list of headings and doesn't try to sort out the nesting.

  • Fix an issue with the "subpage" arrow so it doesn't collide.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

Review Notes

View the main page and use the Contents to navigate to a link within the page.

image

Updated the right-arrow to be an nbsp:

image

srl295 added 2 commits October 9, 2024 12:33
- fix subpage arrow to not conflict
- for now, just a flat list of all headings
@srl295 srl295 requested a review from macchiati October 9, 2024 17:35
@srl295 srl295 self-assigned this Oct 9, 2024
@srl295 srl295 requested review from AEApple and btangmu October 9, 2024 17:35
Copy link

github-actions bot commented Oct 9, 2024

✨ deployed to https://727d250d.cldr.pages.dev

@github-actions github-actions bot added the Site Update Updates docs/site label Oct 9, 2024
btangmu
btangmu previously approved these changes Oct 9, 2024
- Subpages was indented too much, should be on the same level as Contents
@srl295
Copy link
Member Author

srl295 commented Oct 9, 2024

@btangmu very minor update, the subpage header "Subpages" was itself inside a subpage container, so was indented too much.

Copy link

github-actions bot commented Oct 9, 2024

✨ deployed to https://b2a64026.cldr.pages.dev

@srl295 srl295 requested a review from btangmu October 9, 2024 18:08
@macchiati
Copy link
Member

Looks good. I presume that a later PR will combine the Contents and Subpages.

BTW, having the >> in a line at the end of Subpages doesn't look good, and has collisions.

@srl295
Copy link
Member Author

srl295 commented Oct 9, 2024

Looks good.

Thanks!

I presume that a later PR will combine the Contents and Subpages.

Subpages #4119 was already merged.

BTW, having the >> in a line at the end of Subpages doesn't look good, and has collisions.

In the "before" image above or after this PR? Commit a191c52 address this, doesn't it?

@macchiati
Copy link
Member

macchiati commented Oct 9, 2024

Screenshot 2024-10-09 at 12 29 16
I would instead show with CLDR Specifications ❱

@macchiati
Copy link
Member

with a nbsp

@macchiati
Copy link
Member

Subpages #4119 was already merged.

Right, I'm assuming that this will combine the two boxes (I just can't see that on https://b2a64026.cldr.pages.dev/).

macchiati
macchiati previously approved these changes Oct 9, 2024
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great. Any refinement can come in later PR.

- update per review comment- use nbsp instead of float right for arrow symbol
- also, remove a debug printout
Copy link

github-actions bot commented Oct 9, 2024

✨ deployed to https://ed11b4dc.cldr.pages.dev

@srl295
Copy link
Member Author

srl295 commented Oct 9, 2024

Subpages #4119 was already merged.

Right, I'm assuming that this will combine the two boxes (I just can't see that on https://b2a64026.cldr.pages.dev/).

That was a bug, now fixed.

@srl295
Copy link
Member Author

srl295 commented Oct 9, 2024

It looks great. Any refinement can come in later PR.

Take a look now, image above and preview link coming soon.

@srl295
Copy link
Member Author

srl295 commented Oct 9, 2024

@macchiati boxes now merged…

✨ deployed to https://ed11b4dc.cldr.pages.dev

@macchiati
Copy link
Member

Looks great, let's merge!

@srl295 srl295 merged commit 2fbada0 into main Oct 9, 2024
14 checks passed
@srl295 srl295 deleted the srl295/cldr-18001/nav-toc2 branch October 9, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Update Updates docs/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants