Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17999 site: fix some markdown links from https://cldr.unicode.org #4109

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 4, 2024

  • use site relative links

CLDR-17999

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Oct 4, 2024

This comment was marked as outdated.

@github-actions github-actions bot added the Site Update Updates docs/site label Oct 4, 2024
srl295 added 3 commits October 4, 2024 13:31
- pass 2: HTML links in the old download pages
- pass 3  http:// (not https) links in markdown
- pass 4  http:// (not https) links in html

This comment was marked as outdated.

Copy link

github-actions bot commented Oct 4, 2024

✨ deployed to https://37d151f6.cldr.pages.dev

@srl295 srl295 requested review from macchiati, markusicu, AEApple and btangmu and removed request for macchiati and markusicu October 4, 2024 18:39
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Checking Staging will be much easier!

@srl295
Copy link
Member Author

srl295 commented Oct 4, 2024

thanks to @AEApple for catching it

@srl295 srl295 merged commit 2a17138 into main Oct 4, 2024
14 checks passed
@srl295 srl295 deleted the srl295/site/cldr-17999-downloadpages branch October 4, 2024 19:30
@AEApple
Copy link
Contributor

AEApple commented Oct 5, 2024

thanks to @AEApple for catching it

Thank you for fixing it! It will make checking staging a lot easier. I had to keep modifying the links to check staging before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Update Updates docs/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants