CLDR-18001 site: move sitemap to separate page #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ deployed to https://05c12527.cldr.pages.dev |
|
✨ deployed to https://13632e9c.cldr.pages.dev |
|
The box doesn't close if I click elsewhere on the site or a clear option where I can close it out myself. 
|
|
Works nicely for me. Opens new page, and I can get to all the ste pages
from there
…On Wed, Oct 2, 2024, 22:43 Annemarie Apple ***@***.***> wrote:
The box doesn't close if I click elsewhere on the site or a clear option
where I can close it out myself.
Screenshot.2024-10-02.at.10.42.08.PM.png (view on web)
<https://github.com/user-attachments/assets/562be36c-8f13-4d35-8ec4-c6dec51af90d>
—
Reply to this email directly, view it on GitHub
<#4103 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMFX45CGBLUX2USISM3ZZTKRLAVCNFSM6AAAAABPIPCA3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJQGU3TCMZSG4>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
ah, oops. That's a bug… I didn't want the sitemap 'page' to have a closebox, but may have dropped the wrong one |
There was a box to dismiss the 'subpage' popup. it'll be restored with the commit just pushed, please check. Sidebar will be a separate PR, figuring out how to extract the toc. |
|
✨ deployed to https://df166e6c.cldr.pages.dev |
restored X |
macchiati
approved these changes
Oct 3, 2024
|
Looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18001
lot of copy and paste here, to cleanup (modularize) in the future.
ALLOW_MANY_COMMITS=true
sitemap.mdis empty but could have instructions or notes which appear above the sitemap.To review