CLDR-17921 merge DDL v47 branch to main #4087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we re-run ConvertLanguageData on unrelated data, it will update the order and values of some other data -- this fixes inconsistencies with the XML outputs to match expectations. The biggest change was updating values in `language_script.tsv` to demote script variations to secondary when they really are not expected. Furthermore I added explicit annotations to `country_language_population.tsv` when the writing system for a country was a variant. Scripts ran: mvn package -DskipTests=true java -jar tools/cldr-code/target/cldr-code.jar ConvertLanguageData java -jar tools/cldr-code/target/cldr-code.jar GenerateLikelySubtags
macchiati
reviewed
Sep 30, 2024
|
Thanks
…On Mon, Sep 30, 2024, 07:33 Steven R. Loomis ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In common/supplemental/likelySubtags.xml
<#4087 (comment)>:
> @@ -1036,6 +1046,7 @@ not be patched by hand, as any changes made in that fashion may be lost.
<likelySubtag from="und_Ahom" to="aho_Ahom_IN"/> <!--?‧Ahom‧? ➡ Ahom‧Ahom‧India-->
<likelySubtag from="und_Arab" to="ar_Arab_EG"/> <!--?‧Arabic‧? ➡ Arabic‧Arabic‧Egypt-->
<likelySubtag from="und_Arab_AF" to="fa_Arab_AF"/> <!--?‧Arabic‧Afghanistan ➡ Persian‧Arabic‧Afghanistan-->
+ <likelySubtag from="und_Arab_AZ" to="az_Arab_AZ"/> <!--?‧Arabic‧Azerbaijan ➡ Azerbaijani‧Arabic‧Azerbaijan-->
@macchiati <https://github.com/macchiati> this is a branch: i'll add a
comment on the PR.
—
Reply to this email directly, view it on GitHub
<#4087 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMD65WYRZ2JFYY2YXADZZFOLVAVCNFSM6AAAAABO7SIGA6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZXG43DKNZQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
El Salvador has a number of local languages not yet included in CLDR -- this adds them. See https://unicode-org.atlassian.net/browse/CLDR-11567 and https://translatorswithoutborders.org/language-data-for-el-salvador Re-generated the xml with mvn package -DskipTests=true && java -jar tools/cldr-code/target/cldr-code.jar ConvertLanguageData && java -jar tools/cldr-code/target/cldr-code.jar GenerateLikelySubtags
`zlm` and `apd` are not languages of Togo -- there's a copy-paste error in the Likely Subtags overrides. This fixes `apd` (Sudanese Arabic) by adding population counts -- I'll note that the ethnologue estimate is 48,000,000 million people, but the last Sudan census we have in the data shows only ~41 million people in the country -- so I want to be cautious. Since I had problems finding a reliable census I just duplicated the Standard Arabic value since likely most people in Sudan that use Arabic speak the Sudanese dialect but write Standard Arabic/ar. For `zlm` -- Malay (individual language) that's even harder to get a thorough population value so I just fixed the override entry in GenerateLikelySubtags.
srl295
changed the title
|
any concerns with merging? maybe confirm at TC or infra? |
conradarcturus
approved these changes
Oct 2, 2024
|
@macchiati any objection on merging this to main? |
|
Might as well wait for 46 release at this point. |
|
I'll merge once (assuming) it passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To review:
To update this branch:
$ git fetch upstream $ git merge -m 'CLDR-17921 merge from main' upstream/main $ git pushCLDR-17921
ALLOW_MANY_COMMITS=true
DISABLE_JIRA_ISSUE_MATCH=true