CLDR-17947 site: css: update sizes of h1, h2, h3, h4, h5, h6 #4055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ deployed to https://25f0f1d2.cldr.pages.dev |
macchiati
requested changes
Sep 16, 2024
Co-authored-by: Mark Davis <[email protected]>
Co-authored-by: Mark Davis <[email protected]>
|
I have mixed feelings about h4 being italicized. |
|
I do too. Italicizing but being at the same size makes h6 seem more important than h5. I approved because I think we almost never use h6, so I think we could merge this (once conflicts are resolved @srl295 ) |
macchiati
approved these changes
Sep 18, 2024
|
Errs are from old tsv |
|
The changes appear to not yet be active. Eg, an h4 on
https://cldr.unicode.org/ is 20pt, italic
…On Wed, Sep 18, 2024 at 10:50 AM Steven R. Loomis ***@***.***> wrote:
Errs are from old tsv
—
Reply to this email directly, view it on GitHub
<#4055 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMGNVU6GQLAHP7JDPGTZXG4OTAVCNFSM6AAAAABOJ6D7EWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJZGA3TGOJWGM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
conradarcturus
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17947
ALLOW_MANY_COMMITS=true