Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17947 site: pin image width, win fix #4054

Merged
merged 2 commits into from
Sep 16, 2024
Merged

CLDR-17947 site: pin image width, win fix #4054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef6c127
CLDR-17947 site: fix for build on windows
srl295 Sep 16, 2024
d4c0251
CLDR-17947 site: pin max width and height for image
srl295 Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/site/assets/css/page.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,3 +180,8 @@ header#atViewHeader {
div > header {
display: none !important;
}

img {
max-width: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we should use svh & svw

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://dev.to/frehner/css-vh-dvh-lvh-svh-and-vw-units-27k4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macchiati what are you seeing instead? When I used dvh/dvw from your original proposal, the scale didn't work properly- it was far too wide still.

max-height: 90dvh;
}
1 change: 1 addition & 0 deletions docs/site/assets/js/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const coll = new Intl.Collator(["und"]);
async function processFile(d, fullPath, out) {
const f = await fs.readFile(fullPath, "utf-8");
const m = matter(f);
fullPath = fullPath.replace(/\\/g, '/'); // backslash with slash, for win
if (m && m.data) {
const { data } = m;
out.all.push({ ...data, fullPath });
Expand Down
Loading