Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17948 kbd: bump version to v46 #4053

Closed
wants to merge 6 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Sep 13, 2024

CLDR-17948

  • bump schema to support v45 or v46
  • bump test files to v46 - note, these won't compile in keyman until keyman is updated
    • the test mechanism doesn't currently support multiple "old" keyboard versions. In the future, cldr-archive could be leveraged for this.
  • change the ElementAttributeInfo logic to use a new 'special' keyboard XML file, with a DTD, so it can be parsed. This results in a 'no sample file' warning when testing against v45 since that file didn't exist in v45. (But v45 and v46 schemas are identical save for the version number)

This will quell most of the warnings noted in CLDR-17574, CLDR-17745.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295
Copy link
Member Author

srl295 commented Sep 13, 2024

  • keyboard-compile will fail because the compiler has never seen CLDR v46 until this merges.

@macchiati
Copy link
Member

Steven, can you close this or shift to another ticket?

@srl295
Copy link
Member Author

srl295 commented Dec 9, 2024

Steven, can you close this or shift to another ticket?

Obviated by #4118

@srl295 srl295 closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants