CLDR-17893 Clarify rg validation for unit preferences #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
reviewed
Sep 13, 2024
srl295
reviewed
Sep 13, 2024
srl295
reviewed
Sep 13, 2024
srl295
reviewed
Sep 13, 2024
docs/ldml/tr35-info.md
Outdated
| @@ -1239,6 +1239,13 @@ If any key-values are invalid, then they are ignored. Thus the following constru | |||
| | -AA | invalid region 'AA'| | |||
|
|
|||
| ‡ Only the region portion is currently used, so in -rg-usabcdef the "abcdef" is ignored, whether or not it is valid. | |||
There was a problem hiding this comment.
this sentence could be merged with the following (or removed)
|
I added a merge commit to unblock, you can do a git pull to get the latest, or even hit the Squash button and it will get rid of the extra commit. |
srl295
previously approved these changes
Sep 13, 2024
srl295
previously approved these changes
Sep 13, 2024
|
I cleaned it up, so ready for review. |
srl295
approved these changes
Sep 14, 2024
macchiati
deleted the
CLDR-17893-Clarify-rg-validation-for-unit-preferences
branch
haytenf
pushed a commit
to haytenf/cldr
that referenced
this pull request
Sep 17, 2024
Co-authored-by: Steven R. Loomis <[email protected]>
conradarcturus
pushed a commit
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Steven R. Loomis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17893
ALLOW_MANY_COMMITS=true