Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17940 Fix translation for Indochina Time in Tajik. #4047

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

yumaoka
Copy link
Member

@yumaoka yumaoka commented Sep 12, 2024

CLDR-17940

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@yumaoka yumaoka requested review from AEApple and btangmu and removed request for btangmu September 12, 2024 23:27
@srl295
Copy link
Member

srl295 commented Sep 13, 2024

@yumaoka need to merge from main to unbreak without losing the approval, or can use the squash button (may need new approval)

@yumaoka
Copy link
Member Author

yumaoka commented Sep 13, 2024

@yumaoka need to merge from main to unbreak without losing the approval, or can use the squash button (may need new approval)

So the main branch revision I created my brach from was broken (test failure), and I need to rebase my branch with the latest main revision. Can you tell me how to update my branch without losing the approvals?

@srl295
Copy link
Member

srl295 commented Sep 13, 2024

@yumaoka need to merge from main to unbreak without losing the approval, or can use the squash button (may need new approval)

So the main branch revision I created my brach from was broken (test failure), and I need to rebase my branch with the latest main revision. Can you tell me how to update my branch without losing the approvals?

I'd do this (assuming upstream is the main fork)

$ git fetch upstream
$ git merge upstream/main -m 'CLDR-17940 merge from main'
$ git push

it won't lose the approvals.

@yumaoka yumaoka merged commit 0fad39e into unicode-org:main Sep 13, 2024
9 checks passed
@yumaoka yumaoka deleted the tajik-indochina-time branch September 13, 2024 18:51
haytenf pushed a commit to haytenf/cldr that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants