Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17892 ISO 8601 calendar #4037

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Sep 10, 2024

CLDR-17892

Most of the time was in writing something that would show the differences clearly. See the results on:

https://docs.google.com/spreadsheets/d/1fIwEYN8AxoJruBuHuMCoer5WIkEBgFD8i1M2quacJiw/edit

Changes from TC review: now retain the G and 'h...a'.

  • ISO order doesn't allow for DOW, so I put that after the day, thus before the time.

  • The test now makes a few sanity checks, like order of variables

  • Had to modify some other files (PathHeader.*, TestDisplayAndInputProcessor.java)

  • There were a number of failures due to the wrong space, eg around –. (We should check to make sure that DAIP runs on root too!)

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@AEApple
Copy link
Contributor

AEApple commented Sep 10, 2024

Interesting it looks like a lot of the differences in the date ranges may be in spacing. Do you want me to propose edits or wait for tomorrow since I wasn't sure how your are generating this list.

@macchiati
Copy link
Member Author

I put in a column for comments, you can add either a recommended change there or a comment.

@macchiati
Copy link
Member Author

I am generating the spreadsheet contents from the root file. That file has the new calendar iso8601, which aliases the gregorian for names of stuff (months, weekdays, etc), but otherwise uses the explicit patterns that were based on root's version of gregorian.

@AEApple
Copy link
Contributor

AEApple commented Sep 10, 2024

I am generating the spreadsheet contents from the root file. That file has the new calendar iso8601, which aliases the gregorian for names of stuff (months, weekdays, etc), but otherwise uses the explicit patterns that were based on root's version of gregorian.

ah okay! We could use en-CA as a reasonable proxy, for the most part en-CA is intentionally following ISO with a few exceptions.

common/main/root.xml Outdated Show resolved Hide resolved
common/main/root.xml Outdated Show resolved Hide resolved
common/main/root.xml Outdated Show resolved Hide resolved
common/main/root.xml Outdated Show resolved Hide resolved
common/main/root.xml Outdated Show resolved Hide resolved
common/main/root.xml Outdated Show resolved Hide resolved
common/main/root.xml Outdated Show resolved Hide resolved
common/main/root.xml Outdated Show resolved Hide resolved
common/main/root.xml Outdated Show resolved Hide resolved
Copy link
Contributor

@pedberg-icu pedberg-icu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skeletons with h are only allowed to map to patterns with h or K per the spec, see inline comments.

common/main/root.xml Outdated Show resolved Hide resolved
common/main/root.xml Outdated Show resolved Hide resolved
common/main/root.xml Outdated Show resolved Hide resolved
common/main/root.xml Outdated Show resolved Hide resolved
common/main/root.xml Outdated Show resolved Hide resolved
@macchiati
Copy link
Member Author

The tests might not succeed yet, but I'd appreciate review of the output (now with a column for en_CA).

https://docs.google.com/spreadsheets/d/1fIwEYN8AxoJruBuHuMCoer5WIkEBgFD8i1M2quacJiw/edit

@AEApple
Copy link
Contributor

AEApple commented Sep 12, 2024

I added a few questions, I wasn't sure the answers though.

@macchiati
Copy link
Member Author

Interesting it looks like a lot of the differences in the date ranges may be in spacing. Do you want me to propose edits or wait for tomorrow since I wasn't sure how your are generating this list.

I fixed a batch of cases where the space character was caught by tests (normal vs narrow-nobreak).

@AEApple
Copy link
Contributor

AEApple commented Sep 12, 2024

I'm happy to approve since it seems like we just need to make a judgement call for any of the date patterns which are not covered in the ISO spec. Thank you for answering all of my questions.

@macchiati
Copy link
Member Author

ah okay! We could use en-CA as a reasonable proxy, for the most part en-CA is intentionally following ISO with a few exceptions.

I have en-CA in the spreadsheet for comparison. They match pretty well for the pure numeric stuff.

@AEApple
Copy link
Contributor

AEApple commented Sep 12, 2024

Okay, naive question, are any other locales inheriting from root, and if so will this mess up their dates? It does look (at least from the surveytool that 'en' inherits a bunch of values from root.

@macchiati
Copy link
Member Author

What will happen is that the formats

Okay, naive question, are any other locales inheriting from root, and if so will this mess up their dates? It does look (at least from the surveytool that 'en' inherits a bunch of values from root.

Not naive at all. I had added the following to the release page:

  • Added iso8601 patterns to root. These will use localized months, days of the week, day periods, and timezones. In this first version, the separators are not localized, and will use "-" within numeric dates, ":" within times, and " " or ", " between major elements. Full localization will await the next submission phase for CLDR.

<timeFormats>
<timeFormatLength type="full">
<timeFormat>
<pattern>h:mm:ss a zzzz</pattern>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standard patters should use HH per ISO format (this would also make them match the corresponding dateTimeSkeleton...)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in d954cf9 (and spreadsheet).

Copy link
Contributor

@pedberg-icu pedberg-icu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, thanks!

@AEApple
Copy link
Contributor

AEApple commented Sep 12, 2024

I figured out why the AM times confused me for the standard time format examples. I am used to 24 hr times always being zero padded, so when the morning time examples were not zero-padded I automatically read them as 12hr time even though they weren't.

@macchiati macchiati merged commit f2d8a38 into unicode-org:main Sep 12, 2024
12 of 13 checks passed
@macchiati macchiati deleted the CLDR-17892-ISO-8601-calendar branch September 12, 2024 15:48
@macchiati
Copy link
Member Author

All merged

haytenf pushed a commit to haytenf/cldr that referenced this pull request Sep 17, 2024
conradarcturus pushed a commit that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants