Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-15029 Rename unittest.TestUtilities to unittest.TestHelper #4035

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Sep 10, 2024

-Avoid confusion with util.TestUtilities

CLDR-15029

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@btangmu
Copy link
Member Author

btangmu commented Sep 10, 2024

@srl295 This PR seems to be stuck on "license/cla Expected — Waiting for status to be reported"; any idea why or how to give it a nudge?

Also, @macchiati and @srl295 there turn out to be 11 more duplicate class/file names; please see my comment in the ticket for those: https://unicode-org.atlassian.net/browse/CLDR-15029

@btangmu btangmu requested a review from srl295 September 10, 2024 20:16
@srl295
Copy link
Member

srl295 commented Sep 10, 2024

@btangmu the recheck URL is of this form: https://cla-assistant.io/check/unicode-org/cldr?pullRequest=4035

@btangmu
Copy link
Member Author

btangmu commented Sep 10, 2024

the recheck URL ...

FYI I cheated by clicking on Details by "single-commit", then "Update github status"

@btangmu btangmu merged commit ded6d13 into unicode-org:main Sep 10, 2024
13 checks passed
@btangmu btangmu deleted the t15029_a branch September 10, 2024 20:22
@srl295
Copy link
Member

srl295 commented Sep 10, 2024

the recheck URL ...

FYI I cheated by clicking on Details by "single-commit", then "Update github status"

that's the commit checker, not the CLA checker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants