Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17935 site: add crawler sitemap #4028

Merged
merged 1 commit into from
Sep 10, 2024
Merged

CLDR-17935 site: add crawler sitemap #4028

merged 1 commit into from
Sep 10, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Sep 9, 2024 •
edited
Loading

CLDR-17935

  • add sitemap.xml for crawlers

This is unrelated to site organization or navigation. It's so that the crawlers can index the site properly.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Sep 9, 2024
@srl295 srl295 force-pushed the srl295/cldr-17803/nav-sitemap branch from 8a53d09 to 2cb82b9 Compare September 9, 2024 16:02
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/site/assets/css/page.css is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

✨ deployed to https://382b7aa5.cldr.pages.dev

@github-actions github-actions bot added the Site Update Updates docs/site label Sep 9, 2024
macchiati
macchiati requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some work; let's discuss Tuesday

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

✨ deployed to https://094f5448.cldr.pages.dev

@srl295
Copy link
Member Author

srl295 commented Sep 9, 2024

Needs some work; let's discuss Tuesday

I took out the human-readable sitemap.md - a higher priority may be having sitemap.xml in so that when the new site is live, that it is crawlable, because crawlers may or may not be able to navigate the popup menu.

https://094f5448.cldr.pages.dev/sitemap.xml

So, at this point the PR has no visible change, but the sitemap (for crawlers) might be worth getting in as or soon after going live.

@srl295 srl295 requested a review from macchiati September 9, 2024 16:30
@srl295 srl295 changed the title CLDR-17803 site: add sitemap CLDR-17935 site: add crawler sitemap Sep 9, 2024
@srl295
CLDR-17935 site: add sitemap.xml for crawlers.
0fc621c 
This is unrelated to site navigation or appearance.
This does not affect site organization.
@srl295 srl295 force-pushed the srl295/cldr-17803/nav-sitemap branch from 39c6a65 to 0fc621c Compare September 9, 2024 21:57
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/site/assets/js/cldrsite.js is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

✨ deployed to https://4bcec243.cldr.pages.dev

@srl295 srl295 mentioned this pull request Sep 10, 2024
Merged
1 task
conradarcturus
conradarcturus approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@conradarcturus conradarcturus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let the robots in. Looks solid.

@srl295
Copy link
Member Author

srl295 commented Sep 10, 2024

@macchiati any objection?

@srl295 srl295 merged commit 90b987a into main Sep 10, 2024
14 checks passed
@srl295 srl295 deleted the srl295/cldr-17803/nav-sitemap branch September 10, 2024 23:57
@srl295
Copy link
Member Author

srl295 commented Sep 10, 2024

Great… The spiders should pick this up automatically, but I'll update them manually just in case

haytenf pushed a commit to haytenf/cldr that referenced this pull request Sep 17, 2024
@srl295 @haytenf
CLDR-17935 site: add crawler sitemap (unicode-org#4028)
eaba9c3
conradarcturus pushed a commit that referenced this pull request Sep 25, 2024
@srl295 @conradarcturus
CLDR-17935 site: add crawler sitemap (#4028)
02670c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati approved these changes

@conradarcturus conradarcturus conradarcturus approved these changes

@AEApple AEApple Awaiting requested review from AEApple

@btangmu btangmu Awaiting requested review from btangmu

Assignees

@srl295 srl295

Labels
Site Update Updates docs/site
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srl295 @conradarcturus @macchiati