CLDR-14913 Revise VXML generation, further #4017
Conversation
-Remove obsolete admin-OutputAllFiles.jsp and related dead code -Shorten and simplify output; do not write strangely colored vxml xml rxml pxml -Set percent to 100, and status to READY, only if verification is successful -Use SpecialLocales.getType to skip generating locales such as mul_ZZ; still generate algorithmic locales -Use Logger instead of System.out; use at least Level.WARNING since Level.INFO is not displayed (for unknown reasons) -Do not log timing info that depended on deprecated ElapsedTimer -Fix compiler warnings and accept compiler-suggested refactoring -TODO comments
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| finalData = true; | ||
| if (s.equals(VXML_PREFIX)) { | ||
| WebContext ctx = new WebContext(request, response); | ||
| response.sendRedirect(ctx.schemeHostPort() + ctx.base() + VXML_PREFIX + "/"); |
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
There was a problem hiding this comment.
this code isn't really new with this PR, it's just less indented
also doesn't really seem to depend on a user-provide value, though I'm not sure about that...
| ctx.println("<a href='" + ctx.base() + "'>Return to SurveyTool</a><p>"); | ||
| ctx.close(); | ||
| } else if (!s.endsWith(XML_SUFFIX)) { | ||
| response.sendRedirect(ctx.schemeHostPort() + ctx.base() + RXML_PREFIX + "/"); |
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
| finalData = true; | ||
| if (s.equals(TXML_PREFIX)) { | ||
| WebContext ctx = new WebContext(request, response); | ||
| response.sendRedirect(ctx.schemeHostPort() + ctx.base() + TXML_PREFIX + "/"); |
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
| ctx.close(); | ||
| } else if (!s.endsWith(XML_SUFFIX)) { | ||
| WebContext ctx = new WebContext(request, response); | ||
| response.sendRedirect(ctx.schemeHostPort() + ctx.base() + XML_PREFIX + "/"); |
Check warning
Code scanning / CodeQL
URL redirection from remote source Medium
-Remove obsolete admin-OutputAllFiles.jsp and related dead code
-Shorten and simplify output; do not write strangely colored vxml xml rxml pxml
-Set percent to 100, and status to READY, only if verification is successful
-Use SpecialLocales.getType to skip generating locales such as mul_ZZ; still generate algorithmic locales
-Use Logger instead of System.out; use at least Level.WARNING since Level.INFO is not displayed (for unknown reasons)
-Do not log timing info that depended on deprecated ElapsedTimer
-Fix compiler warnings and accept compiler-suggested refactoring
-TODO comments
CLDR-14913
ALLOW_MANY_COMMITS=true