Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17382 languagematch Ukrainian should not fall back to Russian #3993

Merged
merged 2 commits into from
Aug 30, 2024
Merged

CLDR-17382 languagematch Ukrainian should not fall back to Russian #3993

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d3afc6
CLDR-17382 languagematch Ukrainian should not fall back to Russian
stenshamn Aug 28, 2024
0155083
CLDR-17382 languagematch Ukrainian should not fall back to Russian
stenshamn Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion common/supplemental/languageInfo.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,10 @@ For terms of use, see http://www.unicode.org/copyright.html
<languageMatch desired="tt" supported="ru" distance="30" oneway="true"/> <!-- Tatar: tt ⇒ ru -->
<languageMatch desired="tum" supported="en" distance="30" oneway="true"/> <!-- Tumbuka: tum ⇒ en -->
<languageMatch desired="ug" supported="zh" distance="20" oneway="true"/> <!-- Uighur: ug ⇒ zh -->
<languageMatch desired="uk" supported="ru" distance="20" oneway="true"/> <!-- Ukrainian ⇒ Russian -->

<languageMatch desired="uk" supported="en" distance="30" oneway="true"/> <!-- Ukrainian ⇒ English -->
<!-- CLDR-17382: languageMatch: Ukrainian should not fall back to Russian -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case then can we have the comment say that Ukrainian should match with English if we are adding an explicit match?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok to have the explicit fallback to en.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree very much. That's not how this is designed, nor advertised.

stenshamn marked this conversation as resolved.
Show resolved Hide resolved

<languageMatch desired="ur" supported="en" distance="30" oneway="true"/> <!-- Urdu: ur ⇒ en -->
<languageMatch desired="uz" supported="ru" distance="30" oneway="true"/> <!-- Uzbek: uz ⇒ ru -->
<languageMatch desired="wo" supported="fr" distance="30" oneway="true"/> <!-- Wolof: wo ⇒ fr -->
Expand Down
Loading