CLDR-17765 BRS CLDRModify common/annotations; no -fQ; fix ka.xml #3992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Hand-edit annotations/ka.xml to remove 6 / 5000 Результаты перевода -Disable -fQ in CLDRModify.java -Run CLDRModify on common/annotations without options
btangmu
commented
Aug 28, 2024
| @@ -3416,7 +3416,7 @@ Warnings: All cp values have U+FE0F characters removed. See /annotationsDerived/ | |||
| <annotation cp="🧿">ავგაროზი | თილისმა | თურქული თვალი | ნაზარი | ფატიმას თვალი</annotation> | |||
| <annotation cp="🧿" type="tts">ფატიმას თვალი</annotation> | |||
| <annotation cp="🪬">ამულეტი | დაცვა | მარიამი | მირიამი | ფატიმა | ხელი | ჰამსა</annotation> | |||
| <annotation cp="🪬" type="tts">6 / 5000 Результаты перевода ჰამსა</annotation> | |||
| <annotation cp="🪬" type="tts">ჰამსა</annotation> | |||
btangmu
commented
Aug 28, 2024
| @@ -650,11 +650,11 @@ private static void checkSuboptions(int i, UnicodeSet allowedOptions) { | |||
| + "Use -? for help."); | |||
| } | |||
| if (i == FIX && givenOptions.value != null) { | |||
| final UnicodeSet allowedFilters = new UnicodeSet().add('P').add('Q').add('k'); | |||
| final UnicodeSet allowedFilters = new UnicodeSet().add('P').add('k'); | |||
There was a problem hiding this comment.
This is the tooling change to disable -fQ
macchiati
approved these changes
Aug 28, 2024
| @@ -650,11 +650,11 @@ private static void checkSuboptions(int i, UnicodeSet allowedOptions) { | |||
| + "Use -? for help."); | |||
| } | |||
| if (i == FIX && givenOptions.value != null) { | |||
| final UnicodeSet allowedFilters = new UnicodeSet().add('P').add('Q').add('k'); | |||
| final UnicodeSet allowedFilters = new UnicodeSet().add('P').add('k'); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Hand-edit annotations/ka.xml to remove 6 / 5000 Результаты перевода
-Disable -fQ in CLDRModify.java
-Run CLDRModify on common/annotations without options
CLDR-17765
ALLOW_MANY_COMMITS=true