Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17803 docs/site: publish to CloudFlare, config updates #3989

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Aug 27, 2024

CLDR-17803

Note This is a major deployment update - there's still a lot of work todo on the content!

  • docs/site/* deploys to cloudflare
  • PR comment tells you where to go try it example
  • Docker available for local test and build

Split out docs/site* from other stuff in docs/

  • top level config for google sites (such as it is)

  • docs/site just for the site.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

Copy link

✨ deployed to https://6c2617a4.cldr.pages.dev

- docs/site/* deploys to cloudflare
- PR comment tells you where to go try it
- Docker available for local test and build

Split out docs/site* from other stuff in docs/
- top level config for google sites (such as it is)
- docs/site just for the site.
@srl295 srl295 force-pushed the cldr-17803/split-site-config branch from 9597d23 to 479850c Compare August 27, 2024 22:59
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link

✨ deployed to https://69a9a0e3.cldr.pages.dev

@srl295 srl295 marked this pull request as ready for review August 27, 2024 23:00
@srl295
Copy link
Member Author

srl295 commented Aug 27, 2024

@lianghai FYI

@DavidLRowe
Copy link
Contributor

From the https://6c2617a4.cldr.pages.dev/ page, if I click on the "Adding new locales" link, I end up at
https://github.com/unicode-org/cldr/blob/main/docs/requesting_changes.md#adding-new-locales
which I was not expecting. Is this intended?

@srl295
Copy link
Member Author

srl295 commented Aug 27, 2024

From the https://6c2617a4.cldr.pages.dev/ page, if I click on the "Adding new locales" link, I end up at https://github.com/unicode-org/cldr/blob/main/docs/requesting_changes.md#adding-new-locales which I was not expecting. Is this intended?

The content has all kinds of style and navigation problems. The point is that it's deployed somewhere. Then we can improve the content. The "deployed to" messages above are generated whenever the site is updated, and you can check it.

Edit it's actually an improvement on https://unicode-org.github.io/cldr/site/ which had broken CSS.

@macchiati
Copy link
Member

It's hard to tell what is going on, because I only see one page. Are there supposed to be multiple pages hosted?

@srl295
Copy link
Member Author

srl295 commented Aug 28, 2024

It's hard to tell what is going on, because I only see one page. Are there supposed to be multiple pages hosted?

You have to navigate to them directly - so, go to https://69a9a0e3.cldr.pages.dev/downloads/cldr-46

As I said, this is around the deployment, not the content. It's no different from teh issues faced by https://unicode-org.github.io/cldr/site/

We are a ways from replacing cldr.unicode.org but we'll get there.

Please consider approving this incremental improvement.

Copy link

✨ deployed to https://7cb47eee.cldr.pages.dev

@github-actions github-actions bot added the Site Update Updates docs/site label Aug 28, 2024
Copy link

✨ deployed to https://c36409cc.cldr.pages.dev

Copy link

✨ deployed to https://c092d342.cldr.pages.dev

- pre-emptively install wrangler
- see cloudflare/wrangler-action#286 - otherwise wrangler leaves the repo a mess.
Copy link

✨ deployed to https://8a7cc387.cldr.pages.dev

@srl295
Copy link
Member Author

srl295 commented Aug 28, 2024

Could I get a review to merge this?

@srl295 srl295 merged commit 3340398 into main Aug 28, 2024
14 checks passed
@srl295 srl295 deleted the cldr-17803/split-site-config branch August 28, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Update Updates docs/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants