CLDR-11535 Fixes incorrect spacing in currency examples #3976
Conversation
|
I plan to add examples for local currency back (in addition to EUR/USD). |
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
Looking good. You'll just need to add back the old examples. NOTE: The background settings may be confusing; they are supposed to hide the stuff that isn't controlled by the pattern or entity. I will comment more on that in slack. |
srl295
requested review from
pedberg-icu,
macchiati,
conradarcturus and
btangmu
| example = addExampleResult(formatNumber(df_usd, sampleAmount), example, showContexts); | ||
| example = addExampleResult(formatNumber(df_usd, -sampleAmount), example, showContexts); | ||
|
|
||
| DecimalFormat df = icuServiceBuilder.getCurrencyFormat(currency, "¤", numberSystem); |
There was a problem hiding this comment.
Passing "¤" is ugly but seems to work since it is not one of the characters that triggers space insertion
|
| addExampleResult( | ||
| formatNumber(df, -sampleAmount).replace("¤", currencySymbol), | ||
| example, | ||
| showContexts); |
There was a problem hiding this comment.
Where do things stand with this draft PR? it adds more examples, using df_eur and df_usd...
@srl295 I see you made a more recent commit (91e1079) to this method: it returned String but is now void and ends with examples.add(example)
Emiyare also made a more recent commit (00e1fc2) inserting a few lines into this method. It looks like the old changes could be wrapped into the current code fairly easy but not just by rebasing...
CLDR-11535
ALLOW_MANY_COMMITS=true
Before:
After:
