-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17868 v46 BRS: derived annotations, cldrmodify #3970
CLDR-17868 v46 BRS: derived annotations, cldrmodify #3970
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the annotations/* ones were mostly because collation changed.
- new class CLDRTreeWriter - handle writing/deletion/removal properly - updated ca_ES and sr_Cyrl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where missing empty parents aren't added
That is a good addition, for the main directory. Logically, all of the other directories are read in conjunction with main, so an empty file in main is sufficient.
So the tool (and files) needs to be changes to only create empty files, etc in the main directory.
That sounds reasonable, but I think other tooling and tests break with that assumption. Even this generator had a hard coded exception for sr_Cyrl, opting to keep it in place instead of removing it. So TestCLDRFile.TestFileIds is wrong to require en_CA for en_CA_VALENCIA? I think we might need to note this to our users if we were to make a change in v46 and drop intermediate files. Edit The spec doesn't actually mention 'main' being special this way. Could we merge this PR for now and have a follow up to correct the spec and the data? |
I'll file a ticket separately for the parent locale issue. |
CLDR-17906 for further parent locale issues |
CLDR-17868
I also fixed a tool issue that's in several of our tools: where missing empty parents aren't added. New class
CLDRTreeWriter
to support writing a tree full of data. It tracks additions and deletions and fills in missing items. Examples:ca_ES_VALENCIA.xml
is added, it will automatically writeca_ES.xml
sr_Cyrl
it wont' allow it since it has children, it will instead just write an empty file.CLDRTreeWriter
is AutoCloseable ;and must be closed after use.ALLOW_MANY_COMMITS=true