Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17867 BRS: en_001 updates per spreadheet #3953

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Aug 9, 2024

  • skipping dateformats for now but will improve the chart

CLDR-17867

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

- skipping dateformats for now but will improve the chart
@srl295 srl295 self-assigned this Aug 9, 2024
@srl295 srl295 requested review from btangmu, macchiati, DavidLRowe, AEApple, pedberg-icu and DraganBesevic and removed request for btangmu August 9, 2024 20:45
@DavidLRowe
Copy link
Contributor

@srl295 Not sure I'm qualified to review, but did notice this section:

- <annotation cp=":arrows_counterclockwise:">anticlockwise | anticlockwise arrows button | arrow | counterclockwise | counterclockwise arrows button | withershins</annotation>
+ <annotation cp=":arrows_counterclockwise:">again | anticlockwise | arrow | arrows | button | counterclockwise | deja | refresh | rewindershins | vu</annotation>
+ <annotation cp=":arrows_counterclockwise:" type="tts">anticlockwise arrows button</annotation>

Questions:

  • should "deja" and "vu" be together? Or does it matter?
  • "withershins" (which is in the dictionary as equivalent of anticlockwise) was removed and "rewindershins" (which I don't find in the dictionary) added. Might that have been intended as "rewind"?

Otherwise LGTM

@srl295
Copy link
Member Author

srl295 commented Aug 9, 2024

@srl295 Not sure I'm qualified to review, but did notice this section:

- <annotation cp=":arrows_counterclockwise:">anticlockwise | anticlockwise arrows button | arrow | counterclockwise | counterclockwise arrows button | withershins</annotation>
+ <annotation cp=":arrows_counterclockwise:">again | anticlockwise | arrow | arrows | button | counterclockwise | deja | refresh | rewindershins | vu</annotation>
+ <annotation cp=":arrows_counterclockwise:" type="tts">anticlockwise arrows button</annotation>

Questions:

  • should "deja" and "vu" be together? Or does it matter?
  • "withershins" (which is in the dictionary as equivalent of anticlockwise) was removed and "rewindershins" (which I don't find in the dictionary) added. Might that have been intended as "rewind"?

Otherwise LGTM

these match what's in en_GB

Copy link
Contributor

@DavidLRowe DavidLRowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@srl295
Copy link
Member Author

srl295 commented Aug 12, 2024

@macchiati comments here?

@macchiati
Copy link
Member

Checking...

@srl295 srl295 merged commit 6a93ad0 into unicode-org:main Aug 12, 2024
10 checks passed
@srl295 srl295 deleted the cldr-17867/en001 branch August 12, 2024 20:40
@macchiati
Copy link
Member

#3953 (comment)

  • It is ok to separate words; that's consistent with the advice we gave.
  • I can't find any web evidence of rewithershins. It looks like "The opposite of widdershins is deosil, or sunwise, meaning "clockwise"." — https://en.wikipedia.org/wiki/Widdershins.

David, I don't think we need to fix this now, but good catch. Can you file ticket to notify the vetters about this case/

@macchiati
Copy link
Member

macchiati commented Aug 12, 2024 via email

@DavidLRowe
Copy link
Contributor

@macchiati
Copy link
Member

macchiati commented Aug 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants