Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17856 nan and hak in Taiwan #3950

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

DavidLRowe
Copy link
Contributor

CLDR-17856

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati
Copy link
Member

The data changes for language population per region need to be made in the supplemental XML file

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes need to be made in the supplemental XML file.

@srl295
Copy link
Member

srl295 commented Aug 9, 2024

The changes need to be made in the supplemental XML file.

they are made in country_language_population.tsv first, and then ConvertLanguageData is run to update the xml. (Unless we've changed our process?)

@srl295
Copy link
Member

srl295 commented Aug 9, 2024

probably wait until #3952 is merged before this goes in - running ConvertLanguageData to include the xml update.

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macchiati how about we change the spreadsheet, and i'll regenerate the xml as part of my BRS?

@macchiati
Copy link
Member

@macchiati how about we change the spreadsheet, and i'll regenerate the xml as part of my BRS?

You mean, change the tsv? Ok if so.

@srl295
Copy link
Member

srl295 commented Aug 12, 2024

@macchiati how about we change the spreadsheet, and i'll regenerate the xml as part of my BRS?

You mean, change the tsv? Ok if so.

Yes, merge this PR, and then the XML will be regenerated as part of BRS.

@DavidLRowe
Copy link
Contributor Author

@macchiati It seems you need to modify your request for changes.

@srl295 srl295 dismissed macchiati’s stale review August 15, 2024 17:00

dismissed as incorrect

@DavidLRowe DavidLRowe merged commit 9017c5a into unicode-org:main Aug 15, 2024
10 checks passed
@DavidLRowe DavidLRowe deleted the CLDR-17856 branch August 15, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants