Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17866 BRSv46 CLDRModify passes before alpha0, pass2 #3943

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented Aug 7, 2024

CLDR-17866

  • This PR completes the ticket.

CLDRModify passes before alpha1:

  1. With no arguments:
    • en_ZA, remove trailing space after element
    • he, replace entity ref for LRM with actual char
    • others, reorder entries (in annotations, specifically reorder entries for "₨", "﷼" due to collation updates)
  2. With -fP: reformat/reorder exemplar & parseLenient sets, adjust literal quoting.

Note that the -fQ pass was explicitly skipped per Mark comment on previous CLDRModify PR: " I don't think we should add the tts names to the keywords, unless the keywords are empty, because it works against the guidance that people should break up the search keywords by word where possible...I suggest that we hold off adding the tts name, and just do the daip (which reorders)".

Note: This should be merged with a Rebase merge (temporarily enable in Settings), not a Squash merge.

ALLOW_MANY_COMMITS=true

@srl295
Copy link
Member

srl295 commented Aug 7, 2024

I might need to rerun these for #3941

@AEApple
Copy link
Contributor

AEApple commented Aug 7, 2024

Makes sense, but shouldn't we just approve and merge this one and then just do another CLDRModify pass if there are additional changes that need to be modified?

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@srl295
Copy link
Member

srl295 commented Aug 7, 2024

Makes sense, but shouldn't we just approve and merge this one and then just do another CLDRModify pass if there are additional changes that need to be modified?

sorry, i had meant to approve this.

@pedberg-icu pedberg-icu merged commit 7775152 into unicode-org:main Aug 7, 2024
10 checks passed
@pedberg-icu pedberg-icu deleted the CLDR-17866-BRSv46-CLDRModify-before-alpha1 branch August 7, 2024 18:37
@pedberg-icu pedberg-icu changed the title CLDR-17866 BRSv46 CLDRModify passes before alpha1 CLDR-17866 BRSv46 CLDRModify passes before alpha0, pass2 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants