-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17839 Further fixes for Hebrew units #3939
CLDR-17839 Further fixes for Hebrew units #3939
Conversation
Interesting that fixing the directionality has led to a collision failure. |
Yes, the error was hidden before. A "point" (a typographic measure) and "dot" (completely different measure, for screen resolution) are given the same name. Dot can have the same name as pixel, so I propose changing it to that to resolve the issue. |
SGTM! |
…sure) and "dot" (completely different measure, for screen resolution) are given the same name. Dot can have the same name as pixel (and inherits), so changing to inherited.
I'm actually just going to put it on staging for review. |
Nevermind I couldn't figure out how to stage from another fork. I will stage my commit for now. |
You change |
Ping for review |
CLDR-17839
Working off of https://docs.google.com/spreadsheets/d/1dRVt9xb4Ffsf86DrxbPIaj26qVz0GB7DL7yyE9N5pfI/edit?gid=2136703940#gid=2136703940 , which has units that contained {, but didn’t start with {0}.
In particular:
For the future, I think we should provide warnings for problems for vetters.
Important for review!
For example the first changed line shows (old/new):
These look identical when using an English browser to see the Files Changed, but when you paste them into the following and compare the two Memory Position rows, you'll see that the first Memory Position has {0} at the end (pos 33-35) and the second Memory Position has it at the start (pos 25-26)
https://util.unicode.org/UnicodeJsps/bidi.jsp?a=%3CunitPattern+count%3D%22one%22%3E%D7%93%D7%A7%D7%AA+%D7%A7%D7%A9%D7%AA+%7B0%7D%3C%2FunitPattern%3E%0D%0A%3CunitPattern+count%3D%22one%22%3E%7B0%7D+%D7%93%D7%A7%D7%AA+%D7%A7%D7%A9%D7%AA%3C%2FunitPattern%3E&p=Auto
ALLOW_MANY_COMMITS=true