Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-15882 add a test to verify coverage for locale names #3936

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CLDR-15882 add a test to verify coverage for locale names #3936

wants to merge 1 commit into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Aug 6, 2024

CLDR-15882

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Aug 6, 2024
@srl295
Copy link
Member Author

srl295 commented Aug 6, 2024

Note, a bunch of failures:

CLDR {
  LikelySubtagsTest {
    TestMissingInfoForLanguage {
      Error: (LikelySubtagsTest.java:371) Language ak: fix coverageLevels.txt: Expected MODERN but got comprehensive for //ldml/localeDisplayNames/languages/language[@type="ak"] - tcLocale:true, locale calculated coverage:moderate
      Error: (LikelySubtagsTest.java:371) Language ee: fix coverageLevels.txt: Expected MODERN but got comprehensive for //ldml/localeDisplayNames/languages/language[@type="ee"] - tcLocale:true, locale calculated coverage:basic
      Error: (LikelySubtagsTest.java:371) Language gaa: fix coverageLevels.txt: Expected MODERN but got comprehensive for //ldml/localeDisplayNames/languages/language[@type="gaa"] - tcLocale:true, locale calculated coverage:basic
      Error: (LikelySubtagsTest.java:371) Language ii: fix coverageLevels.txt: Expected MODERN but got comprehensive for //ldml/localeDisplayNames/languages/language[@type="ii"] - tcLocale:false, locale calculated coverage:basic
      Error: (LikelySubtagsTest.java:371) Language nb: fix coverageLevels.txt: Expected MODERN but got comprehensive for //ldml/localeDisplayNames/languages/language[@type="nb"] - tcLocale:true, locale calculated coverage:modern
      Error: (LikelySubtagsTest.java:371) Language nso: fix coverageLevels.txt: Expected MODERN but got comprehensive for //ldml/localeDisplayNames/languages/language[@type="nso"] - tcLocale:true, locale calculated coverage:basic
      Error: (LikelySubtagsTest.java:371) Language om: fix coverageLevels.txt: Expected MODERN but got comprehensive for //ldml/localeDisplayNames/languages/language[@type="om"] - tcLocale:true, locale calculated coverage:basic
      Error: (LikelySubtagsTest.java:371) Language rw: fix coverageLevels.txt: Expected MODERN but got comprehensive for //ldml/localeDisplayNames/languages/language[@type="rw"] - tcLocale:true, locale calculated coverage:basic
      Error: (LikelySubtagsTest.java:371) Language st: fix coverageLevels.txt: Expected MODERN but got comprehensive for //ldml/localeDisplayNames/languages/language[@type="st"] - tcLocale:true, locale calculated coverage:basic
      Error: (LikelySubtagsTest.java:371) Language tn: fix coverageLevels.txt: Expected MODERN but got comprehensive for //ldml/localeDisplayNames/languages/language[@type="tn"] - tcLocale:true, locale calculated coverage:basic

macchiati
macchiati requested changes Aug 6, 2024
View reviewed changes
tools/cldr-code/src/test/java/org/unicode/cldr/unittest/LikelySubtagsTest.java
@@ -349,6 +356,30 @@ public void TestMissingInfoForLanguage() {
}
errln("Missing English translation for: " + language + " which is at " + covLevel);
}
// now, check general coverage level. Use "und" so it is neutral.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the check that should only be done if the last-release's effective coverage level is > Modern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati requested changes

@DavidLRowe DavidLRowe Awaiting requested review from DavidLRowe

@AEApple AEApple Awaiting requested review from AEApple

@btangmu btangmu Awaiting requested review from btangmu

@pedberg-icu pedberg-icu Awaiting requested review from pedberg-icu

@DraganBesevic DraganBesevic Awaiting requested review from DraganBesevic

Requested changes must be addressed to merge this pull request.

Assignees

@srl295 srl295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srl295 @macchiati