Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16844 Show the Dashboard by default, and remember user preference #3934

Merged
merged 6 commits into from
Aug 5, 2024
Merged

CLDR-16844 Show the Dashboard by default, and remember user preference #3934

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d29d6c
CLDR-16844 Show the Dashboard by default, and remember user preference
btangmu Aug 3, 2024
a9d34c1
CLDR-16844 Show the Dashboard by default, and remember user preference
btangmu Aug 3, 2024
832d698
CLDR-16844 Revise getClient to use await
btangmu Aug 5, 2024
924e68d
CLDR-16844 Revise getClient, no new/await; vue property for open-dash
btangmu Aug 5, 2024
98d59be
CLDR-16844 Fix vue property for open-dash
btangmu Aug 5, 2024
72bfb70
CLDR-16844 Comment out cldr-overall-errors in vue
btangmu Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tools/cldr-apps/js/src/views/GeneralInfo.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
@click="insertDashboard"
class="cldr-nav-btn btn-primary open-dash"
type="button"
v-if="!dashButtonShouldBeVisible()"
v-if="dashButtonShouldBeVisible()"
>
Open Dashboard
</button>

<!-- <cldr-overall-errors /> -->
<cldr-overall-errors />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, did you mean to re-enable this? Why? I think we need to discuss first!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw it too just after the commit, sorry about the noise! It was temporary for testing the call to cldrClient that motivated the whole tangent

</div>
</template>

Expand Down
Loading