CLDR-17843 Update ug.xml Add missing values to keep basic coverage. #3922
Conversation
Arabic and Arabic Extended are missing number formats -- just inherit. Same for symbols. Separately the exemplar characters need to be updated too. https://unicode-org.atlassian.net/browse/CLDR-17843
|
remember we'll need to regenerate coverageLevels.txt after this merges as in #3897 |
|
I'm not able to run the "build" and "check" jobs -- is it a permissions thing? Waiting on that, all of my pull requests are blocked right now. |
|
Probably permissions
El El vie, ago 2, 2024 a la(s) 5:49 p.m., Conrad Nied <
***@***.***> escribió:
… I'm not able to run the "build" and "check" jobs -- is it a permissions
thing? Waiting on that, all of my pull requests are blocked right now.
—
Reply to this email directly, view it on GitHub
<#3922 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGQZM22QTLI42SBXADDX2TZPQEGRAVCNFSM6AAAAABLY3FRKCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRWGIZTCNBQGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
| @@ -1157,7 +1157,7 @@ Reviewed by Waris Abdukerim Janbaz <[email protected]> of the Uyghur Computer Sci | |||
| <exemplarCharacters type="auxiliary">[\u200E\u200F ئ]</exemplarCharacters> | |||
| <exemplarCharacters type="index" draft="contributed">[{ئا} {ئه} {ئو} {ئۇ} {ئۆ} {ئۈ} {ئې} {ئى} ا ە ب پ ت ج چ خ د ر ز ژ س ش غ ف ق ك گ ڭ ل م ن ھ و ۇ ۆ ۈ ۋ ې ى ي]</exemplarCharacters> | |||
There was a problem hiding this comment.
Re {...} on this like: The {} are needed in the index IF they surround a string with 2+ characters, and that sequence (eg, {ئا}) is something that in used in indexing (eg {SCH} is used in German indexes).
They punctuation was failing a test because I did not escape the curly braces. Also re-ran coverage level script `java -jar tools/cldr-code/target/cldr-code.jar ShowLocaleCoverage`
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
| @@ -152,6 +152,7 @@ tn ; basic ; Tswana | |||
| to ; basic ; Tongan | |||
| tr ; modern ; Turkish | |||
| tt ; moderate ; Tatar | |||
| ug ; basic ; Uyghur | |||
There was a problem hiding this comment.
This will be overridden as soon as common/properties/coverageLevels.txt is regenerated. But harmless, so approving.
There was a problem hiding this comment.
Does that happen automatically or does that happen if a contributor runs the script? After this commit it should be always covered.
I figured this is a good test to prove my commit works too ;)
|
It gets rebuilt when we rebuild the charts. We currently don't do that with pushes (it takes a while), but we've talked about doing something like every day. (Or we could rebuild just part of the charts). |
I think an additional job that runs on main (maybe daily) that signals if the rebuild makes a difference could be a lower impact way to handle this. Then we'd get notification, the charts are out of date, click here to update (as it'd be already built). |
Arabic and Arabic Extended are missing number formats -- just inherit. Same for symbols. Separately the exemplar characters need to be updated too.
https://unicode-org.atlassian.net/browse/CLDR-17843
CLDR-17843
ALLOW_MANY_COMMITS=true