CLDR-17843 Update xnr.xml -- Add scaffolding for Kangri Devanagari nu… #3921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
approved these changes
Jul 31, 2024
|
remember we'll need to regenerate coverageLevels.txt after this merges as in #3897 |
…mber formatting patterns We don't have submitted data for the Devanagari numerals in the Kangri language -- so we'll fall back to what Hindi is doing, which is just to inherit parent values atm. This will prevent Kangri from dropping in coverage level.
…agari digits In order to prevent Kuvi from dropping in coverage, this updates the number formats to inherit from root, otherwise it will be considered to be missing information.
…ols inherit same format as root Adding N'Ko update to the PR. In order to prevent N'Ko from dropping in coverage, this updates number formats for their native digits to re-use the patterns from Latin -- while there may be differences we will request confirmation from linguists later.
srl295
reviewed
Aug 5, 2024
conradarcturus
force-pushed
the
CLDR-17843-Fix-locales-about-to-drop-in-coverage-1
branch
from
ec094f4 to
3307be2
Compare
|
Fix applied, please re-review |
The child locales of Kuvi needed inheritance as well so I fixed that too. Also re-ran the coverage levels `java -jar tools/cldr-code/target/cldr-code.jar ShowLocaleCoverage`
conradarcturus
force-pushed
the
CLDR-17843-Fix-locales-about-to-drop-in-coverage-1
branch
from
cca247c to
b2dc0c8
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
srl295
approved these changes
Aug 7, 2024
conradarcturus
deleted the
CLDR-17843-Fix-locales-about-to-drop-in-coverage-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mber formatting patterns
We don't have submitted data for the Devanagari numerals in the Kangri language -- so we'll fall back to what Hindi is doing, which is just to inherit parent values atm.
This will prevent Kangri from dropping in coverage level.
CLDR-17843
ALLOW_MANY_COMMITS=true
DISABLE_JIRA_ISSUE_MATCH=true