Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-7401 Add examples for quarters and eras #3917

Merged
merged 1 commit into from
Aug 20, 2024
Merged

CLDR-7401 Add examples for quarters and eras #3917

merged 1 commit into from
Aug 20, 2024

Conversation

haytenf
Copy link
Contributor

@haytenf haytenf commented Jul 30, 2024 •
edited
Loading

CLDR-7401 Add examples for quarters and eras

QUARTER Examples, LOCALE=am
(Before)
am_quarters_BEFORE
(After)
am_quarters_winning_AFTER
am_quarters_other_AFTER

QUARTER Examples, LOCALE=it
(Before)
it_quarters_BEFORE
(After)
it_quarters_AFTER

ERA Examples, LOCALE=am
(Before)
am_eras_BEFORE
(After)
am_eras_AFTER

ERA Examples, LOCALE=ja
(Before)
ja_eras_BEFORE
(After)
ja_eras_AFTER

ERA Examples, LOCALE=fi
(Before)
fi_eras_before
(After)
fi_eras_en_AFTER
fi_eras_winning_AFTER
fi_eras_other_AFTER

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@haytenf haytenf force-pushed the CLDR-7401-add-examples-for-eras-and-other-date-fields branch from 4ecead0 to e3a17e0 Compare July 31, 2024 17:26
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java is different
  • tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestExampleGenerator.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@haytenf haytenf force-pushed the CLDR-7401-add-examples-for-eras-and-other-date-fields branch from e3a17e0 to dd746a2 Compare July 31, 2024 17:29
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java is different
  • tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestExampleGenerator.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@haytenf haytenf force-pushed the CLDR-7401-add-examples-for-eras-and-other-date-fields branch from dd746a2 to 32c6d4b Compare July 31, 2024 18:10
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestExampleGenerator.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@haytenf haytenf force-pushed the CLDR-7401-add-examples-for-eras-and-other-date-fields branch from 32c6d4b to a9428b4 Compare August 1, 2024 02:38
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@haytenf haytenf marked this pull request as ready for review August 1, 2024 03:05
@haytenf haytenf requested a review from macchiati August 9, 2024 19:06
macchiati
macchiati requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things

tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java Show resolved Hide resolved
tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java Show resolved Hide resolved
tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java Outdated Show resolved Hide resolved
tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestExampleGenerator.java Outdated Show resolved Hide resolved
@haytenf haytenf force-pushed the CLDR-7401-add-examples-for-eras-and-other-date-fields branch from 666d719 to 61f582e Compare August 13, 2024 02:13
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@haytenf haytenf requested a review from macchiati August 13, 2024 16:51
@macchiati
Copy link
Member

Hi, this has conflicts that need resolution. Can you do that? (If you don't know how, ask on Slack.).

macchiati
macchiati previously approved these changes Aug 19, 2024
View reviewed changes
@macchiati
Copy link
Member

That is, I approved, but will need to reapprove once the conflicts are resolved.

@macchiati
Copy link
Member

A commit statement failed. You will need to hit Details on the jira-ticket line above, and squash

@haytenf haytenf force-pushed the CLDR-7401-add-examples-for-eras-and-other-date-fields branch from 1ca905f to 9e56b98 Compare August 20, 2024 13:48
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@haytenf
Copy link
Contributor Author

haytenf commented Aug 20, 2024

Thanks, I've just squashed. All the checks look good from my end now.

@macchiati macchiati merged commit 3be00b6 into unicode-org:main Aug 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macchiati macchiati macchiati approved these changes

Assignees

@haytenf haytenf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haytenf @CLAassistant @macchiati