Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17675 Revert the decimal/grouping change, but … #3908

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Jul 25, 2024

Obsolete PR — see #3909

Revert the decimal/grouping change, but add alts to allow implementations to choose between official and us variant.

From the discussion in the Design meeting, we agreed on 2 variants, plus the default, as the normal pattern. That allows implementations to pick among the two choices by name — without having to know which was the default — or pick the default. People are also in favor of using semantic alt names, rather than just 'variant'.

Still draft because I want to pass this by the TC; there were a couple of things I wanted to get feedback on.

  1. I think the decision was to go with the official syntax (12,34) for the default, but wanted feedback.
  2. For the US style, I used alt="us", as probably the most recognizable term. But other suggestions are welcome. (Perhaps alt="period"?)
  3. The ticket also mentioned R5,87 as the standard currency format, eg no space between currency alphabetics and the digits. That is in place also.

CLDR-17675

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

…implementations to choose between official and variant
@macchiati
Copy link
Member Author

BTW, I'm getting some bizarre errors; will have to look into those.

TestDateFormatsWithContext
Error:  (TestExampleGenerator.java:830)  Error: : Currency format example faulty: expected "【٥‏/٩‏/١٩٩٩〗【⃪٥‏/٩‏/١٩٩٩〗", got "【5‏/9‏/1999〗【⃪5‏/9‏/1999〗"
    TestScriptOfSample
Error:  (TestScriptMetadata.java:57)  Error: : Zinh: The sample character must have a single, valid script, no ScriptExtensions: -9: expected true
...

@macchiati
Copy link
Member Author

Bitten again by github being sensitive to special characters in a branch name. Sigh. Will need to close this PR and do another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant