Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17832 BRSv46 CLDRModify passes before alpha0 #3900

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented Jul 24, 2024

CLDR-17832

  • This PR completes the ticket.

CLDRModify passes before alpha0:

  1. With no arguments: In personName data, add xml:space="preserve" where necessary.
  2. With -fQ: In annotations, copy tts name into keywords, reorder keywords as necessary.
  3. With -fP: In main zh_Latn, reformat exemplars.
  4. Pass 2 above (-fQ) made some annotation keyword lists too long, so revert those 20 cases (in cs, eu, no, ro)

Note: This should be merged with a Rebase merge (temporarily enable in Settings), not a Squash merge.

ALLOW_MANY_COMMITS=true

@pedberg-icu
Copy link
Contributor Author

pedberg-icu commented Jul 24, 2024

To merge this when approved: Go into settings, check "Allow rebase merging", then in the PR use the popup next to the "Squash and merge" button to instead select "Rebase merge" and merge with that (to keep commits distinct on main), then go back to Settings and uncheck "Allow rebase merging".

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I should have raised this earlier. I don't think we should add the tts names to the keywords, unless the keywords are empty, because it works against the guidance that people should break up the search keywords by word where possible.

I suggest that we hold off adding the tts name, and just do the daip (which reorders).

@pedberg-icu
Copy link
Contributor Author

... I don't think we should add the tts names to the keywords... I suggest that we hold off adding the tts name, and just do the daip (which reorders).

OK, at this point then I think the easiest thing is just to abandon this PR and start over, skipping the -fQ pass.

@pedberg-icu pedberg-icu deleted the CLDR-17832-BRSv46-CLDRModify-before-alpha0 branch July 24, 2024 22:52
@macchiati
Copy link
Member

macchiati commented Jul 24, 2024 via email

@pedberg-icu
Copy link
Contributor Author

This is replaced with PR #3903

@pedberg-icu
Copy link
Contributor Author

In that case shall I go ahead and merge the pound currency sign PR?

@macchiati Yes (and you already did, and the newer CLDRModify in PR #3903 updates those parseLenient sets)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants