-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17832 BRSv46 CLDRModify passes before alpha0 #3900
CLDR-17832 BRSv46 CLDRModify passes before alpha0 #3900
Conversation
To merge this when approved: Go into settings, check "Allow rebase merging", then in the PR use the popup next to the "Squash and merge" button to instead select "Rebase merge" and merge with that (to keep commits distinct on main), then go back to Settings and uncheck "Allow rebase merging". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I should have raised this earlier. I don't think we should add the tts names to the keywords, unless the keywords are empty, because it works against the guidance that people should break up the search keywords by word where possible.
I suggest that we hold off adding the tts name, and just do the daip (which reorders).
OK, at this point then I think the easiest thing is just to abandon this PR and start over, skipping the -fQ pass. |
In that case shall I go ahead and merge the pound currency sign PR?
…On Wed, Jul 24, 2024 at 3:52 PM Peter Edberg ***@***.***> wrote:
Closed #3900 <#3900>.
—
Reply to this email directly, view it on GitHub
<#3900 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMBO7HLKIPL4ECKFUUTZOAVZ3AVCNFSM6AAAAABLNI7UJCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGYZTOMJQHE3DANQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
This is replaced with PR #3903 |
@macchiati Yes (and you already did, and the newer CLDRModify in PR #3903 updates those parseLenient sets) |
CLDR-17832
CLDRModify passes before alpha0:
Note: This should be merged with a Rebase merge (temporarily enable in Settings), not a Squash merge.
ALLOW_MANY_COMMITS=true