-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17566 pre-test github pages before merge to main, also fix some items #3868
CLDR-17566 pre-test github pages before merge to main, also fix some items #3868
Conversation
- even on PRs, we should build the gh-pages action to make sure there aren't syntax errs.
hooray it failed
|
10cb436
to
9123fe9
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
- use a raw tag for liquid, see: <https://talk.jekyllrb.com/t/code-block-is-improperly-handled-and-generates-liquid-syntax-error/7599/2>
9123fe9
to
c4ea20b
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
||
abbreviated {{NUMBER\_OF\_WEEKS, plural, | ||
```xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chpy04 this wasn't needed but i decided to put this in an XML code fence.
The real fix is the {% raw…
directive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me (but not knowing yml...)
CLDR-17566
ALLOW_MANY_COMMITS=true