Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17566 pre-test github pages before merge to main, also fix some items #3868

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Jul 15, 2024

CLDR-17566

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

- even on PRs, we should build the gh-pages action to make sure there aren't syntax errs.
@srl295 srl295 self-assigned this Jul 15, 2024
@srl295
Copy link
Member Author

srl295 commented Jul 15, 2024

hooray it failed

      Generating... 
  Liquid Exception: Liquid syntax error (line 111): Variable '{{NUMBER\_OF\_WEEKS, plural, =0 {0 wks}' was not properly terminated with regexp: /\}\}/ in site/development/development-process/design-proposals/xmb.md
/opt/hostedtoolcache/Ruby/3.2.4/x64/lib/ruby/gems/3.2.0/gems/liquid-4.0.4/lib/liquid/block_body.rb:136:in `raise_missing_variable_terminator': Liquid syntax error (line 111): Variable '{{NUMBER\_OF\_WEEKS, plural, (Liquid::SyntaxError)

@srl295 srl295 force-pushed the cldr-17566/try-building-pages branch from 10cb436 to 9123fe9 Compare July 15, 2024 22:45
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/site/development/development-process/design-proposals/xmb.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 changed the title CLDR-17566 fix pages action to always build CLDR-17566 pre-test github pages before merge to main, also fix some items Jul 15, 2024
@srl295 srl295 force-pushed the cldr-17566/try-building-pages branch from 9123fe9 to c4ea20b Compare July 15, 2024 22:48
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot


abbreviated {{NUMBER\_OF\_WEEKS, plural,
```xml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chpy04 this wasn't needed but i decided to put this in an XML code fence.

The real fix is the {% raw… directive.

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me (but not knowing yml...)

@srl295 srl295 merged commit 5e7cedf into unicode-org:main Jul 16, 2024
9 checks passed
@srl295 srl295 deleted the cldr-17566/try-building-pages branch July 16, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants