Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17492 deps: update js deps #3866

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Jul 12, 2024

CLDR-17492

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 added the dependencies Pull requests that update a dependency file label Jul 12, 2024
@srl295 srl295 requested a review from btangmu July 12, 2024 18:58
@srl295 srl295 self-assigned this Jul 12, 2024
srl295 added 2 commits July 12, 2024 14:12
 - deps: nodenv/actions/node-version@v4
 - retry js test once if it fails.
 - update puppeteer deps
@srl295 srl295 force-pushed the cldr-17492/auditfix branch from a7413f5 to 19e04be Compare July 12, 2024 19:27
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/js.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

- there's a whole issue about how we invoke FE tests that needs fixing.
@srl295 srl295 marked this pull request as draft July 12, 2024 19:33
@srl295
Copy link
Member Author

srl295 commented Jul 12, 2024

There's a whole problem with how we do the FE tests that prevents this. I will ahve to come back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants