Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17402 json: drop _cldrVersion path #3863

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Jul 12, 2024

  • drop //ldml/identity/version entirely (was producing _cldrVersion in every file)
  • also, annotate the code working around CLDR-17790 as a TODO
  • As a reminder, this will greatly reduce the diffs every time json is updated.

CLDR-17402

  • This PR completes the ticket.

Example output with this change:

--- a/cldr-json/cldr-units-modern/main/zh/measurementSystemNames.json
+++ b/cldr-json/cldr-units-modern/main/zh/measurementSystemNames.json
@@ -2,9 +2,6 @@
   "main": {
     "zh": {
       "identity": {
-        "version": {
-          "_cldrVersion": "46"
-        },
         "language": "zh"
       },
       "localeDisplayNames": {

ALLOW_MANY_COMMITS=true

- drop //ldml/identity/version entirely (was producing _cldrVersion in every file)
- also, annotate the code working around CLDR-17790 as a TODO
@srl295 srl295 self-assigned this Jul 12, 2024
Copy link
Member

@btangmu btangmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a lot of code involving "//ldml/identity/version" and this PR even adds a little bit more such code. Am I right in guessing that such paths are still required in some circumstances, such as in XML, even though they're no longer required in JSON?

@srl295
Copy link
Member Author

srl295 commented Jul 12, 2024

There's still a lot of code involving "//ldml/identity/version" and this PR even adds a little bit more such code. Am I right in guessing that such paths are still required in some circumstances, such as in XML, even though they're no longer required in JSON?

  • The data is part of the DTD, so needs to be present for backwards compatibility in XML.
  • It's used in JSON, but it's extracted into the package manifest by other code.
  • The version is read in XML by other Java code.

@srl295 srl295 merged commit 6f048e4 into unicode-org:main Jul 15, 2024
11 checks passed
@srl295 srl295 deleted the cldr-17402/json-drop-ver branch July 15, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants