Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-8823 Tool for grouping calendars by behavior #3862

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Jul 12, 2024

CLDR-8823

Here is the current data generated. Shane was also interested in having something like this metadata for calendars in cldr, to help distinguish features of the calendars and set some constraints on behavior. To be discussed is what that would look like in XML.

Note that the days/month suppress the case where the month only has the max value. The columns max days/year and max months/year are computable from the corresponding detail columns. The data is generated by the code, which cycles over 1000 years just to catch edge cases. (If there are any other edge cases for calendars we should add them).

Calendars max days/year max months/year max days/month days/year months/year days/month
islamic islamic-civil islamic-rgsa islamic-tbla islamic-umalqura 355 12 30 354 355 12 2=29 4=29 6=29 8=29 10=29 12=29,30
indian 366 12 31 365 366 12 1=30,31 7=30 8=30 9=30 10=30 11=30 12=30
gregorian iso8601 buddhist japanese roc 366 12 31 365 366 12 2=28,29 4=30 6=30 9=30 11=30
persian 366 12 31 365 366 12 7=30 8=30 9=30 10=30 11=30 12=29,30
coptic ethiopic ethiopic-amete-alem 366 13 30 365 366 13 13=5,6
chinese dangi 385 13 30 353 354 355 383 384 385 12 13 1=29,30 2=29,30 3=29,30 4=29,30 5=29,30 6=29,30 7=29,30 8=29,30 9=29,30 10=29,30 11=29,30 12=29,30 13=29,30
hebrew 385 13 30 353 354 355 383 384 385 12 13 2=29,30 3=29,30 4=29 6=29,30 7=29,30 8=29,30 9=29,30 10=29,30 11=29,30 12=29,30 13=29
  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

pedberg-icu
pedberg-icu previously approved these changes Jul 12, 2024
srl295
srl295 previously approved these changes Jul 12, 2024
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. even if we don't have this as concrete metadata (which we should), this could inform the coverage and pathheader tests.

@macchiati macchiati dismissed stale reviews from srl295 and pedberg-icu via 70b1e7c July 13, 2024 04:58
@macchiati macchiati requested review from srl295 and pedberg-icu July 13, 2024 05:06
@macchiati
Copy link
Member Author

Made some fixes to the data, mostly fixes for oddities in Chinese/Hebrew calendars

@macchiati macchiati requested a review from sffc July 13, 2024 22:53
Copy link
Contributor

@mihnita mihnita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.
M.

@macchiati macchiati merged commit 1015d7d into unicode-org:main Jul 16, 2024
10 checks passed
@macchiati macchiati deleted the CLDR-8823-Tool-for-grouping-calendars-by-behavior branch July 16, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants