Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16933 Allow names for noon, midnight to match adjacent non-fixed dayPeriods; add tests & spec note #3857

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented Jul 9, 2024

CLDR-16933

  • This PR completes the ticket.
  • Test adjustments needed to resolve an error in Ukrainian and perhaps also needed for other locales, per discussion in ticket:
    • Let midnight match a non-fixed period that starts at, ends at, or contains midnight (both 00:00 and 24:00)
    • Let noon match a non-fixed period that starts at, ends at, or contains noon (or just before noon);
  • Add unit tests for this and for some other dayPeriodRuleSet name allowances we are already making.
  • Add a spec note about formatting noon and midnight; these may not need an explicit numeric time, unless the same name is used for other dayPeriods.

ALLOW_MANY_COMMITS=true

@pedberg-icu pedberg-icu merged commit 229b635 into unicode-org:main Jul 9, 2024
11 checks passed
@pedberg-icu pedberg-icu deleted the CLDR-16933-allow-noon-midnight-to-match-adjacent-periods branch July 9, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants